Date: Tue, 26 Jul 2005 10:02:30 -0700 From: Peter Wemm <peter@wemm.org> To: "Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=" <des@des.no> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Jung-uk Kim <jkim@freebsd.org> Subject: Re: cvs commit: src/sys/boot/i386/libi386 Makefile libi386.h smbios.c src/sys/boot/i386/loader main.c Message-ID: <200507261002.31596.peter@wemm.org> In-Reply-To: <86oe8phlq1.fsf@xps.des.no> References: <200507141952.j6EJqMVQ009846@repoman.freebsd.org> <86oe8phlq1.fsf@xps.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 26 July 2005 04:04 am, Dag-Erling Smørgrav wrote:
> Jung-uk Kim <jkim@FreeBSD.org> writes:
> > Log:
> > Scan static SMBIOS structures and export the following
> > environment variables to loader: [...]
>
> These values are sometimes padded, IWBNI libi386 could remove that
> padding:
>
> hint.smbios.0.system.maker="Dell Inc. "
> hint.smbios.0.system.product="Dimension XPS Gen 3 "
>
> also, there's a typo in one of the strings:
>
> Hint.smbios.0.planar.version=" "
>
> (note the capital H)
It's not a typo. Its got the wrong number of fields so the hint scanner
disables it.
if (strncmp(cp, "hint.", 5) != 0)
hit = 0;
else
n = sscanf(cp, "hint.%32[^.].%d.%32[^=]=%128s",
r_name, &r_unit, r_resname, r_value);
if (hit && n != 4) {
printf("CONFIG: invalid hint '%s'\n", cp);
p = index(cp, 'h');
*p = 'H';
hit = 0;
}
hint.smbios.0.planar.version is an illegal hint. It has 5 fields, not
4. These are not free-form strings.
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507261002.31596.peter>