Date: Sun, 26 Jul 2020 22:30:01 +0000 (UTC) From: Xin LI <delphij@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r363584 - head/sys/geom Message-ID: <202007262230.06QMU1Xw084792@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: delphij Date: Sun Jul 26 22:30:01 2020 New Revision: 363584 URL: https://svnweb.freebsd.org/changeset/base/363584 Log: geom_map and geom_redboot: Remove unused ctlreq handler. The two classes do not take any verbs and always gctl_error for all requests, so don't bother to provide a ctlreq handler. Reviewed by: mav MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D25810 Modified: head/sys/geom/geom_map.c head/sys/geom/geom_redboot.c Modified: head/sys/geom/geom_map.c ============================================================================== --- head/sys/geom/geom_map.c Sun Jul 26 19:51:42 2020 (r363583) +++ head/sys/geom/geom_map.c Sun Jul 26 22:30:01 2020 (r363584) @@ -387,24 +387,11 @@ g_map_taste(struct g_class *mp, struct g_provider *pp, return (gp); } -static void -g_map_config(struct gctl_req *req, struct g_class *mp, const char *verb) -{ - struct g_geom *gp; - - g_topology_assert(); - gp = gctl_get_geom(req, mp, "geom"); - if (gp == NULL) - return; - gctl_error(req, "Unknown verb"); -} - static struct g_class g_map_class = { .name = MAP_CLASS_NAME, .version = G_VERSION, .taste = g_map_taste, .dumpconf = g_map_dumpconf, - .ctlreq = g_map_config, }; DECLARE_GEOM_CLASS(g_map_class, g_map); MODULE_VERSION(geom_map, 0); Modified: head/sys/geom/geom_redboot.c ============================================================================== --- head/sys/geom/geom_redboot.c Sun Jul 26 19:51:42 2020 (r363583) +++ head/sys/geom/geom_redboot.c Sun Jul 26 22:30:01 2020 (r363584) @@ -336,24 +336,11 @@ again: return (gp); } -static void -g_redboot_config(struct gctl_req *req, struct g_class *mp, const char *verb) -{ - struct g_geom *gp; - - g_topology_assert(); - gp = gctl_get_geom(req, mp, "geom"); - if (gp == NULL) - return; - gctl_error(req, "Unknown verb"); -} - static struct g_class g_redboot_class = { .name = REDBOOT_CLASS_NAME, .version = G_VERSION, .taste = g_redboot_taste, .dumpconf = g_redboot_dumpconf, - .ctlreq = g_redboot_config, .ioctl = g_redboot_ioctl, }; DECLARE_GEOM_CLASS(g_redboot_class, g_redboot);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202007262230.06QMU1Xw084792>