Date: Fri, 3 Dec 1999 01:54:10 -0800 (PST) From: Julian Elischer <julian@whistle.com> To: Maxim Sobolev <sobomax@altavista.net> Cc: Archie Cobbs <archie@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bpf.h bpf_filter.c Message-ID: <Pine.BSF.4.10.9912030152270.14114-100000@current1.whistle.com> In-Reply-To: <38478BB2.4B119713@altavista.net>
next in thread | previous in thread | raw e-mail | index | archive | help
i
On Fri, 3 Dec 1999, Maxim Sobolev wrote:
> Archie Cobbs wrote:
>
> > archie 1999/12/02 11:36:06 PST
> >
> > Modified files:
> > sys/net bpf.h bpf_filter.c
> > Log:
> > Add 'const' to the bpf_filter() and bpf_validate() prototypes.
> > Remove a stale comment from bpf_validate().
>
> It seems that this commit broke kernel builds for kernels w/o "pseudo-device
> bpf":
>
> cc -c -O2 -pipe -march=pentium -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual
> -fformat -extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include
> -DKERNEL -include opt_global.h -D_KERNEL -elf -mpreferred-stack-boundary=2
> ../../net/bpf.c
> ../../net/bpf.c: In function `bpf_filter':
> ../../net/bpf.c:1316: argument `pc' doesn't match prototype
> ../../net/bpf.h:234: prototype declaration
> *** Error code 1
>
>
does the following fix it?
cvs server: Diffing .
Index: bpf.c
===================================================================
RCS file: /cvs/freebsd/src/sys/net/bpf.c,v
retrieving revision 1.57
diff -c -r1.57 bpf.c
*** bpf.c 1999/11/03 21:32:28 1.57
--- bpf.c 1999/12/03 09:54:22
***************
*** 1309,1315 ****
u_int
bpf_filter(pc, p, wirelen, buflen)
! register struct bpf_insn *pc;
register u_char *p;
u_int wirelen;
register u_int buflen;
--- 1309,1315 ----
u_int
bpf_filter(pc, p, wirelen, buflen)
! register const struct bpf_insn *pc;
register u_char *p;
u_int wirelen;
register u_int buflen;
Note: apply by hand.. cut'n'pasted..
> -Maxim
>
>
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9912030152270.14114-100000>