Date: Wed, 28 Jan 2015 08:18:44 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk Message-ID: <86vbjrl6ej.fsf@nine.des.no> References: <201501260850.t0Q8oDna015719@svn.freebsd.org> <86fvax91cy.fsf@nine.des.no> <F9F10CE5-3282-4BDF-AA65-9FF1F994412E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Garrett Cooper <yaneurabeya@gmail.com> writes: > I disagree for a few reasons: > 1. style.Makefile(9) makes no mention of having to use an idiom over > the other. That is only one of many things it does not mention. That doesn't mean we don't have idioms and conventions outside what is described in that document. > 2. The likelihood of typos creeping into Makefiles is greater with the > _foo=3D idiom. I don't see how it makes a difference at all. > 3. It creates unnecessary local variables =E2=80=94 especially when appen= ding > is so easy to do. Define unnecessary. What is the marginal cost of a Makefile variable? > 4. It=E2=80=99s more difficult when backporting changes to do it with the > variable method =E2=80=94 especially if context around the line modified = has > changed a great deal. I don't see how it makes a difference. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86vbjrl6ej.fsf>