Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Jul 2024 14:21:45 GMT
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 67faf45be5d6 - stable/14 - cxgbe(4): Initialize mps_bg_map to an invalid value if it's not known.
Message-ID:  <202407171421.46HELjNd029601@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by np:

URL: https://cgit.FreeBSD.org/src/commit/?id=67faf45be5d67830497914ef807f536ba98d4e32

commit 67faf45be5d67830497914ef807f536ba98d4e32
Author:     Navdeep Parhar <np@FreeBSD.org>
AuthorDate: 2024-04-30 19:51:29 +0000
Commit:     Navdeep Parhar <np@FreeBSD.org>
CommitDate: 2024-07-17 06:38:00 +0000

    cxgbe(4): Initialize mps_bg_map to an invalid value if it's not known.
    
    Sponsored by:   Chelsio Communications
    
    (cherry picked from commit 9de0036b55dcdabc54fa69ea6e583b22d739818c)
---
 sys/dev/cxgbe/common/t4_hw.c | 2 +-
 sys/dev/cxgbe/t4_main.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/cxgbe/common/t4_hw.c b/sys/dev/cxgbe/common/t4_hw.c
index 8d109b389f0d..755062909e14 100644
--- a/sys/dev/cxgbe/common/t4_hw.c
+++ b/sys/dev/cxgbe/common/t4_hw.c
@@ -6742,7 +6742,7 @@ static unsigned int t4_get_mps_bg_map(struct adapter *adap, int idx)
 {
 	u32 n;
 
-	if (adap->params.mps_bg_map)
+	if (adap->params.mps_bg_map != UINT32_MAX)
 		return ((adap->params.mps_bg_map >> (idx << 3)) & 0xff);
 
 	n = adap->params.nports;
diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c
index b41746828e9e..4834a4fc2873 100644
--- a/sys/dev/cxgbe/t4_main.c
+++ b/sys/dev/cxgbe/t4_main.c
@@ -5333,7 +5333,7 @@ get_params__post_init(struct adapter *sc)
 	if (rc == 0)
 		sc->params.mps_bg_map = val[0];
 	else
-		sc->params.mps_bg_map = 0;
+		sc->params.mps_bg_map = UINT32_MAX;	/* Not a legal value. */
 
 	/*
 	 * Determine whether the firmware supports the filter2 work request.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202407171421.46HELjNd029601>