Date: Wed, 17 Sep 1997 18:37:11 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@FreeBSD.ORG, julian@whistle.com Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern subr_log.c subr_rlist.c tty_pty.c tty_snoop.c tty_tty.c uipc_domain.c vfs_subr.c src/sys/net bpf.c netisr.h route.c src/sys/netinet igmp.c in_proto.c ip_fw.h tcp_subr.c src/sys/sys buf.h exe Message-ID: <199709170837.SAA08987@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>I think this has been discussed before..
>but...
>WHY!!!!!
It (tty_tty.c in this example) had 90% KNF-style 100% K&R1-supporting
code until someone spammed devfs support into it.
>in the example given I think the original made more sense,
>and didn't we vote to stop adding more of the stupid __P() stuff?
We voted not to require it in new code.
>from this commit.....
>***************
>*** 179,186 ****
> static void *ctty_devfs_token;
> #endif
>
> static void
>! ctty_drvinit(void *unused)
> {
> dev_t dev;
>
>--- 179,188 ----
> static void *ctty_devfs_token;
> #endif
>
>+ static void ctty_drvinit __P((void *unused));
> static void
>! ctty_drvinit(unused)
>! void *unused;
> {
> dev_t dev;
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709170837.SAA08987>