Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Jun 2017 09:53:08 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Pedro Giffuni <pfg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r320146 - head/sys/fs/ext2fs
Message-ID:  <1497973988.81013.78.camel@freebsd.org>
In-Reply-To: <10f2e743-7b55-4a8d-1479-b5b3de9b4fe2@FreeBSD.org>
References:  <201706201435.v5KEZJdr075723@repo.freebsd.org> <10f2e743-7b55-4a8d-1479-b5b3de9b4fe2@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2017-06-20 at 10:48 -0500, Pedro Giffuni wrote:
> ...
> 
> On 20/06/2017 09:35, Pedro F. Giffuni wrote:
> > 
> > Author: pfg
> > Date: Tue Jun 20 14:35:19 2017
> > New Revision: 320146
> > URL: https://svnweb.freebsd.org/changeset/base/320146
> > 
> > Log:
> >    Improve grammar concerning "metadata".
> >    
> >    Remove unnecessary space while here.
> > 
> > Modified:
> >    head/sys/fs/ext2fs/ext2fs.h
> > 
> > Modified: head/sys/fs/ext2fs/ext2fs.h
> > ===================================================================
> > ===========
> > --- head/sys/fs/ext2fs/ext2fs.h	Tue Jun 20 14:28:51 2017	
> > (r320145)
> > +++ head/sys/fs/ext2fs/ext2fs.h	Tue Jun 20 14:35:19 2017	
> > (r320146)
> > @@ -316,9 +316,8 @@ struct ext2_gd {
> >   	uint16_t ext4bgd_csum;		/* group descriptor
> > checksum */
> >   };
> >   
> > -
> > -/* EXT2FS metadatas are stored in little-endian byte order. These
> > macros
> > - * helps reading these metadatas
> > +/* EXT2FS metadata is stored in little-endian byte order. These
> > macros
> > + * helps reading them.
> >    */
> >   
> For the record: "metadata" is tricky as it can be addressed to
> either 
> plural or singular, what is wrong the use of "metadatas".
> 
> Pedro.
> 

Metadata can be treated as if singular or plural for purposes of making
an associated verb match in number.  That's a different issue from the
fact that "metadatas" just isn't a word at all.

Speaking of making subject and verb match in number, the verb in the
3rd sentence needs to be "help".

-- Ian




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1497973988.81013.78.camel>