Date: Wed, 10 Dec 2008 14:50:04 -0500 From: John Baldwin <jhb@freebsd.org> To: "Paul B. Mahol" <onemda@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] MPSAFE/LOOKUP_SHARED cd9660 Message-ID: <200812101450.04638.jhb@freebsd.org> In-Reply-To: <3a142e750812100922m553be9c6sdcd81d98c81c7ab4@mail.gmail.com> References: <200811191510.53793.jhb@FreeBSD.org> <200812091602.10850.jhb@freebsd.org> <3a142e750812100922m553be9c6sdcd81d98c81c7ab4@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 10 December 2008 12:22:43 pm Paul B. Mahol wrote: > On 12/9/08, John Baldwin <jhb@freebsd.org> wrote: > > The RRIP stuff is all done in cd9660_vget_internal() under an exclusive > > lock. > > It could be a property of the ISO image. "PX" holds permissions (owner, > > etc.). Do you get the same messages w/o the patch with the same ISO image / > > CD? > > > > -- > > John Baldwin > > > > I searched little for this message and found kern/63446 PR interesting comment: > > Caused by cd9660_vnops.c rev. 1.77. VOP_READDIR returns bogus > d_fileno, VFS_VGET on this value returns bogus vnode with zeroed attributes. > > I think that whatever locking is done is done wrong. That issue isn't a locking issue, it's an issue with VOP_READDIR() using a different meaning for i-node numbers than VFS_VGET(), and would happen regardless of any Giant or vnode locking. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812101450.04638.jhb>