Date: Thu, 10 Jun 2010 17:49:36 +0000 (UTC) From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r208992 - head/sys/geom Message-ID: <201006101749.o5AHnaFQ020793@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: trasz Date: Thu Jun 10 17:49:36 2010 New Revision: 208992 URL: http://svn.freebsd.org/changeset/base/208992 Log: Untangle g_print_bio(), silencing Coverity. Found with: Coverity Prevent CID: 3566, 3567 Modified: head/sys/geom/geom_io.c Modified: head/sys/geom/geom_io.c ============================================================================== --- head/sys/geom/geom_io.c Thu Jun 10 17:04:01 2010 (r208991) +++ head/sys/geom/geom_io.c Thu Jun 10 17:49:36 2010 (r208992) @@ -779,19 +779,18 @@ g_print_bio(struct bio *bp) return; case BIO_READ: cmd = "READ"; + break; case BIO_WRITE: - if (cmd == NULL) - cmd = "WRITE"; + cmd = "WRITE"; + break; case BIO_DELETE: - if (cmd == NULL) - cmd = "DELETE"; - printf("%s[%s(offset=%jd, length=%jd)]", pname, cmd, - (intmax_t)bp->bio_offset, (intmax_t)bp->bio_length); - return; + cmd = "DELETE"; + break; default: cmd = "UNKNOWN"; printf("%s[%s()]", pname, cmd); return; } - /* NOTREACHED */ + printf("%s[%s(offset=%jd, length=%jd)]", pname, cmd, + (intmax_t)bp->bio_offset, (intmax_t)bp->bio_length); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006101749.o5AHnaFQ020793>