Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Apr 2021 00:56:26 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: de87ea5a43a8 - stable/13 - struct mount uppers: correct locking annotations
Message-ID:  <202104110056.13B0uQpm014331@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=de87ea5a43a850079b5f8901795f3769c85c6f89

commit de87ea5a43a850079b5f8901795f3769c85c6f89
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-04-08 22:03:06 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-04-11 00:35:23 +0000

    struct mount uppers: correct locking annotations
    
    (cherry picked from commit 5af1131de7fc18c795ed28e69d9393f78875d3e5)
---
 sys/sys/mount.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sys/sys/mount.h b/sys/sys/mount.h
index e6a74bf1fb60..8b5712d19215 100644
--- a/sys/sys/mount.h
+++ b/sys/sys/mount.h
@@ -196,6 +196,7 @@ _Static_assert(sizeof(struct mount_pcpu) == 16,
  * 	l - mnt_listmtx
  *	m - mountlist_mtx
  *	i - interlock
+ *	i* - interlock of uppers' list head
  *	v - vnode freelist mutex
  *
  * Unmarked fields are considered stable as long as a ref is held.
@@ -240,8 +241,8 @@ struct mount {
 	struct vnodelst	mnt_lazyvnodelist;	/* (l) list of lazy vnodes */
 	int		mnt_lazyvnodelistsize;	/* (l) # of lazy vnodes */
 	struct lock	mnt_explock;		/* vfs_export walkers lock */
-	TAILQ_ENTRY(mount) mnt_upper_link;	/* (m) we in the all uppers */
-	TAILQ_HEAD(, mount) mnt_uppers;		/* (m) upper mounts over us*/
+	TAILQ_ENTRY(mount) mnt_upper_link;	/* (i*) we in the all uppers */
+	TAILQ_HEAD(, mount) mnt_uppers;		/* (i) upper mounts over us */
 };
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104110056.13B0uQpm014331>