Date: Thu, 5 Apr 2018 15:20:53 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Alexander Motin <mav@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331701 - in head: cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/zpool cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzfs/common cddl/contrib/opensol... Message-ID: <aae71fe1-3018-86a6-1441-4450e20e119c@FreeBSD.org> In-Reply-To: <201803282201.w2SM1RTe029674@repo.freebsd.org> References: <201803282201.w2SM1RTe029674@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29/03/2018 01:01, Alexander Motin wrote:
> MFV r331695, 331700: 9166 zfs storage pool checkpoint
>
> illumos/illumos-gate@8671400134a11c848244896ca51a7db4d0f69da4
>
> The idea of Storage Pool Checkpoint (aka zpool checkpoint) deals with
> exactly that. It can be thought of as a “pool-wide snapshot” (or a
> variation of extreme rewind that doesn’t corrupt your data). It remembers
> the entire state of the pool at the point that it was taken and the user
> can revert back to it later or discard it. Its generic use case is an
> administrator that is about to perform a set of destructive actions to ZFS
> as part of a critical procedure. She takes a checkpoint of the pool before
> performing the actions, then rewinds back to it if one of them fails or puts
> the pool into an unexpected state. Otherwise, she discards it. With the
> assumption that no one else is making modifications to ZFS, she basically
> wraps all these actions into a “high-level transaction”.
A small nit:
> /* check options */
> - while ((c = getopt(argc, argv, ":aCc:d:DEfFmnNo:R:T:VX")) != -1) {
> + while ((c = getopt_long(argc, argv, ":aCc:d:DEfFmnNo:rR:T:VX",
> + long_options, NULL)) != -1) {
> switch (c) {
It seems that on illumos zpool import has an undocumented option with no effect,
-r. I think that we removed that option from FreeBSD. This commit restored it.
I am actually indifferent about having it. Just pointing out this possibly
unintended change.
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aae71fe1-3018-86a6-1441-4450e20e119c>