Date: Fri, 6 May 2011 16:32:04 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: current@freebsd.org, multimedia@freebsd.org Subject: Re: dsp mmap change Message-ID: <20110506133204.GE48734@deviant.kiev.zoral.com.ua> In-Reply-To: <4DC3B764.4030801@FreeBSD.org> References: <4DC3B764.4030801@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, May 06, 2011 at 11:55:00AM +0300, Andriy Gapon wrote: > > I would like to ask for a review and/or testing of the following patch: > http://people.freebsd.org/~avg/dev_dsp_mmap.diff > > It's supposed to fix an issue described here: > http://lists.freebsd.org/pipermail/freebsd-multimedia/2011-February/011691.html > > In short, the following pseudo-code should do the right thing: > fd = open(/dev/dsp, O_RDWR); > mmap(PROT_READ, fd); > mmap(PROT_WRITE, fd); > > Thank you! I think that you have to call PCM_GIANT_LEAVE() when returning EINVAL on the vm_pager_alloc() failure. Your patch hardcodes an assumption that sndbufs are always contiguous. I was unable to convince myself that this is true. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk3D+FMACgkQC3+MBN1Mb4hSCwCg3jrBuja6zxUakMlfEtxo0K8R XGUAn1l+mZr+eJeH7cGIbdTnue9PvPZS =nIgf -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110506133204.GE48734>