Date: Wed, 4 Feb 2015 22:44:11 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r278223 - head/lib/clang Message-ID: <FDF569F1-E61B-4B60-B54A-A9B5D2E0ADBD@FreeBSD.org> In-Reply-To: <CAGHfRMB3d0uqJUO00M6fKzXkFjBOqZt5JodCQYWVNbKRLrkGHw@mail.gmail.com> References: <201502042100.t14L0Ued055489@svn.freebsd.org> <CAGHfRMCKxHXpnr38orBiWMEpXsgAVhZ1ViOcdswGEezRvnKoVw@mail.gmail.com> <7338E032-8668-44D2-AE98-C3E50E512DDD@FreeBSD.org> <CAGHfRMB3d0uqJUO00M6fKzXkFjBOqZt5JodCQYWVNbKRLrkGHw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A4D962F5-2F03-4490-9D4B-5C2682E83516 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 04 Feb 2015, at 22:23, NGie Cooper <yaneurabeya@gmail.com> wrote: > > On Wed, Feb 4, 2015 at 1:16 PM, Dimitry Andric <dim@freebsd.org> wrote: >> On 04 Feb 2015, at 22:09, NGie Cooper <yaneurabeya@gmail.com> wrote: >>> >>> On Wed, Feb 4, 2015 at 1:00 PM, Dimitry Andric <dim@freebsd.org> wrote: >>>> Author: dim >>>> Date: Wed Feb 4 21:00:29 2015 >>>> New Revision: 278223 >>>> URL: https://svnweb.freebsd.org/changeset/base/278223 >>>> >>>> Log: >>>> For now, add -stdlib=libc++ to the flags for building clang, since that >>>> makes it easier to build head on stable/9, where libstdc++ is still the >>>> default. We can revisit this when somebody will try to build base with >>>> gcc 4.8.1 or higher, and its included libstdc++. >>> >>> Maybe this should be conditionalized on COMPILER_TYPE? >> >> COMPILER_TYPE doesn't say anything about the C++ library used. Maybe we >> need a CXX_LIBRARY_TYPE setting for it? >> >> That said, you may be right that it should be conditionalized on the >> compiler type anyway, since gcc does not support the -stdlib= option. > > Yeah... true. > My original point was coming more from a perspective that this was > being done strictly for the GNU toolchain, so conditionalizing the > CFLAGS on the compiler being used seemed reasonable. This flag is only relevant when you are 1) using clang to compile, and 2) on freebsd 9.x. You cannot compile clang in head with base gcc anyway. -Dimitry --Apple-Mail=_A4D962F5-2F03-4490-9D4B-5C2682E83516 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTSkqsACgkQsF6jCi4glqOTLgCeOrh0cqhZ7WGSFHGxNTvktTm5 yM4An0uqBLFizkwIWhd1WPsmtvCD3avX =1jQO -----END PGP SIGNATURE----- --Apple-Mail=_A4D962F5-2F03-4490-9D4B-5C2682E83516--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FDF569F1-E61B-4B60-B54A-A9B5D2E0ADBD>