Date: Thu, 7 Dec 2023 23:02:09 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Alan Somers <asomers@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>, li-Wen Hsu <lwhsu@freebsd.org> Subject: Re: git: 6b96125afdf2 - main - cap_net.3: remove a copypasta Message-ID: <5DC76457-C348-49C6-8EDE-763EB014D9DC@FreeBSD.org> In-Reply-To: <CAOtMX2gvox5qfm8dASpD-4Z3qAqM8v13BRUBs8fKWa98Gm_hpQ@mail.gmail.com> References: <202312061652.3B6GqOuf068349@gitrepo.freebsd.org> <44E8C9F3-84DD-4E51-B2A4-FB56E2A08F30@FreeBSD.org> <CAOtMX2gvox5qfm8dASpD-4Z3qAqM8v13BRUBs8fKWa98Gm_hpQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_75CB8794-64FC-46C6-A8B3-8588880C3BE4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Dec 7, 2023, at 11:59 AM, Alan Somers <asomers@freebsd.org> wrote: >=20 > On Wed, Dec 6, 2023 at 6:55=E2=80=AFPM Zhenlei Huang <zlei@freebsd.org = <mailto:zlei@freebsd.org>> wrote: >>=20 >>=20 >>=20 >>> On Dec 7, 2023, at 12:52 AM, Alan Somers <asomers@freebsd.org> = wrote: >>>=20 >>> The branch main has been updated by asomers: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6b96125afdf245ae61dd82b59891ad0d= 6aab0066 >>>=20 >>> commit 6b96125afdf245ae61dd82b59891ad0d6aab0066 >>> Author: Alan Somers <asomers@FreeBSD.org> >>> AuthorDate: 2023-12-05 23:23:29 +0000 >>> Commit: Alan Somers <asomers@FreeBSD.org> >>> CommitDate: 2023-12-06 16:51:37 +0000 >>>=20 >>> cap_net.3: remove a copypasta >>>=20 >>> This line appears to have been copied from cap_sysctl.3. While = I'm >>> here, reorder and reword the description of cap_net_limit a bit. >>>=20 >>> [skip ci] >>=20 >> I guess we can 'skip ci' implicitly for document or typo changes. >=20 > Can we? The skipping logic is builtin to Jenkins, Github Workflows, > and Cirrus. I don't think it would be easy to program any of those to > detect which changes can be safely skipped. Sorry for the misleading word 'can', I think it is accurate to reword it = to 'want to'. 1. To detect document changes, I think checking the names of changed = files is sufficient. 2. As for the typo change, we can check the commit log. A false detecting (if the change is SKIP CI candidate) does not hurt = much, as it will be queued up to next running of CI. So I think the simple logic above is practical. > -Alan --Apple-Mail=_75CB8794-64FC-46C6-A8B3-8588880C3BE4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Dec 7, 2023, at 11:59 AM, Alan Somers <<a = href=3D"mailto:asomers@freebsd.org" class=3D"">asomers@freebsd.org</a>>= wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><meta= charset=3D"UTF-8" class=3D""><span style=3D"caret-color: rgb(0, 0, 0); = font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">On Wed, Dec 6, 2023 at 6:55=E2=80=AFPM Zhenlei Huang = <</span><a href=3D"mailto:zlei@freebsd.org" style=3D"font-family: = Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; orphans: auto; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px;" class=3D"">zlei@freebsd.org</a><span = style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; = font-size: 13px; font-style: normal; font-variant-caps: normal; = font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none; float: none; display: inline !important;" class=3D"">> = wrote:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: = Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none;" class=3D""><blockquote type=3D"cite" style=3D"font-family: = Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; orphans: auto; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><br = class=3D""><br class=3D""><br class=3D""><blockquote type=3D"cite" = class=3D"">On Dec 7, 2023, at 12:52 AM, Alan Somers <<a = href=3D"mailto:asomers@freebsd.org" class=3D"">asomers@freebsd.org</a>>= wrote:<br class=3D""><br class=3D"">The branch main has been updated by = asomers:<br class=3D""><br class=3D"">URL: <a = href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D6b96125afdf245ae61dd82b5= 9891ad0d6aab0066" = class=3D"">https://cgit.FreeBSD.org/src/commit/?id=3D6b96125afdf245ae61dd8= 2b59891ad0d6aab0066</a><br class=3D""><br class=3D"">commit = 6b96125afdf245ae61dd82b59891ad0d6aab0066<br class=3D"">Author: = Alan Somers <<a = href=3D"mailto:asomers@FreeBSD.org" = class=3D"">asomers@FreeBSD.org</a>><br class=3D"">AuthorDate: = 2023-12-05 23:23:29 +0000<br class=3D"">Commit: = Alan Somers <<a = href=3D"mailto:asomers@FreeBSD.org" = class=3D"">asomers@FreeBSD.org</a>><br class=3D"">CommitDate: = 2023-12-06 16:51:37 +0000<br class=3D""><br = class=3D""> cap_net.3: remove a copypasta<br class=3D""><br = class=3D""> This line appears to have been copied from = cap_sysctl.3. While I'm<br class=3D""> here, reorder = and reword the description of cap_net_limit a bit.<br class=3D""><br = class=3D""> [skip ci]<br class=3D""></blockquote><br = class=3D"">I guess we can 'skip ci' implicitly for document or typo = changes.<br class=3D""></blockquote><br style=3D"caret-color: rgb(0, 0, = 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">Can we? The skipping logic is builtin to Jenkins, = Github Workflows,</span><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">and Cirrus. I don't think it would be easy to program = any of those to</span><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">detect which changes can be safely skipped.</span><br = style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; = font-size: 13px; font-style: normal; font-variant-caps: normal; = font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none;" class=3D""></div></blockquote><div><br class=3D""></div><div>Sorry = for the misleading word 'can', I think it is <span = style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);" = class=3D"">accurate to</span> reword it to 'want to'.</div><div><br = class=3D""></div><div>1. To detect document changes, I think checking = the names of changed files is sufficient.</div><div>2. As for the typo = change, we can check the commit log.</div><div><br class=3D""></div><div>A= false detecting (if the change is SKIP CI candidate) does not hurt = much, as it will be queued up</div><div>to next running of CI. So I = think the simple logic <span style=3D"caret-color: rgb(0, 0, 0); = color: rgb(0, 0, 0);" class=3D"">above is = practical.</span></div><div><br class=3D""></div><blockquote type=3D"cite"= class=3D""><div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); = font-family: Menlo-Regular; font-size: 13px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">-Alan</span></div></blockquote></div><br class=3D""><div = class=3D""> <div><br class=3D""></div> </div> <br class=3D""></body></html>= --Apple-Mail=_75CB8794-64FC-46C6-A8B3-8588880C3BE4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5DC76457-C348-49C6-8EDE-763EB014D9DC>