Date: Fri, 19 Sep 2008 00:16:41 -0400 (EDT) From: Daniel Eischen <deischen@freebsd.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: Kostik Belousov <kostikbel@gmail.com>, current@freebsd.org Subject: Re: Fwd: Pending MFC Reminder [cvs commit: src/lib/libc/uuid Symbol.map] Message-ID: <Pine.GSO.4.64.0809190001160.22342@sea.ntplx.net> In-Reply-To: <bb4a86c70809181549y2c2e00b7k385fa9f1e41eba1f@mail.gmail.com> References: <200809180023.m8I0NEJY032390@freefall.freebsd.org> <bb4a86c70809181134v477dae29t1fd9d8933920dda@mail.gmail.com> <20080918195049.GQ39652@deviant.kiev.zoral.com.ua> <bb4a86c70809181549y2c2e00b7k385fa9f1e41eba1f@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 18 Sep 2008, Maksim Yevmenkin wrote: >> > emax 2008-09-15 23:54:55 UTC >> > >> > FreeBSD src repository >> > >> > Modified files: >> > lib/libc/uuid Symbol.map >> > Log: >> > SVN rev 183058 on 2008-09-15 23:54:55Z by emax >> > >> > Add uuid_enc,dec_le,be() functions to Symbol.map >> > Pointy hat goes to me. >> > >> > MFC after: 3 days >> > >> > Revision Changes Path >> > 1.3 +4 -0 src/lib/libc/uuid/Symbol.map >> >> >> I has a question against original commit, that I missed when reading >> commit mail. Why the new symbols introduced after 7.0 is released, >> where added to the FBSD_1.0 version ? I think FBSD_1.1 is correct >> there. >> >> Do you object ? Any symbols added to HEAD (8.x) go in FBSD_1.1. Symbols in HEAD always go to the latest version which is FBSD_1.1. Any symbols that are MFC'd, have to go to the _same_ version as they went to in HEAD (FBSD_1.1). What you must not do is MFC symbols to a different version in 7.x (or, more generally, any previous release/branch) than the version from which they came. If newfoo is in FBSD_1.1 in HEAD, then it has to be in FBSD_1.1 in 7.x. If you want to get picky and keep all 7.x versions in FBSD_1.0.x, then you first have to add FBSD_1.0.x in HEAD and add the symbols there. But that has not been the convention to date. Remember that all symbols and versions in 7.x _must_ be present in HEAD before they are MFC'd. HEAD is always a superset of 7.x. If you have added something to 7.x that doesn't exist in the same version as HEAD (in this case, FBSD_1.1), then please back it out and correct it. -- DE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.64.0809190001160.22342>