Date: Fri, 9 Aug 2013 16:03:33 -0400 From: John Baldwin <jhb@freebsd.org> To: current@freebsd.org Subject: HEAD in dubious state after 254141 Message-ID: <201308091603.33445.jhb@freebsd.org>
next in thread | raw e-mail | index | archive | help
--Boundary-00=_VsUBSGAELqL+1H/ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit I'm in the process of reverting 254150 and 254141. I think the changes in 254141 were from an old tree that wasn't updated for the changes in 254138 and I don't seen an obvious way to fix 254141, so until Attilio can redo 254141 I'm going to revert these. -- John Baldwin --Boundary-00=_VsUBSGAELqL+1H/ Content-Type: message/rfc822; name="forwarded message" Content-Transfer-Encoding: 7bit Content-Description: John Baldwin <jhb@freebsd.org>: Re: svn commit: r254150 - head/sys/vm Content-Disposition: inline Return-Path: <owner-src-committers@FreeBSD.org> Received: from bigwig.baldwin.cx ([unix socket]) by bigwig.baldwin.cx (Cyrus v2.3.16) with LMTPA; Fri, 09 Aug 2013 15:58:35 -0400 X-Sieve: CMU Sieve 2.3 Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:1900:2254:206a::19:2]) by bigwig.baldwin.cx (Postfix) with ESMTP id 40651B978 for <john@baldwin.cx>; Fri, 9 Aug 2013 15:58:34 -0400 (EDT) Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.freebsd.org (Postfix) with ESMTPS id 9BE157BFF for <john@baldwin.cx>; Fri, 9 Aug 2013 19:58:33 +0000 (UTC) Received: by hub.freebsd.org (Postfix) id 7D524E0; Fri, 9 Aug 2013 19:58:33 +0000 (UTC) Delivered-To: jhb@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 5DDA06D; Fri, 9 Aug 2013 19:58:33 +0000 (UTC) Delivered-To: src-committers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C59B16B; Fri, 9 Aug 2013 19:58:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9ADEB2E88; Fri, 9 Aug 2013 19:58:27 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 62210B939; Fri, 9 Aug 2013 15:58:26 -0400 (EDT) From: John Baldwin <jhb@freebsd.org> To: "David E. O'Brien" <obrien@freebsd.org> Subject: Re: svn commit: r254150 - head/sys/vm Date: Fri, 9 Aug 2013 15:56:47 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p28; KDE/4.5.5; amd64; ; ) Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201308091643.r79GhoWx023884@svn.freebsd.org> In-Reply-To: <201308091643.r79GhoWx023884@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201308091556.47535.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 09 Aug 2013 15:58:26 -0400 (EDT) Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 09 Aug 2013 15:58:34 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.97.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on bigwig.baldwin.cx X-Length: 3938 X-UID: 69454 On Friday, August 09, 2013 12:43:50 pm David E. O'Brien wrote: > Author: obrien > Date: Fri Aug 9 16:43:50 2013 > New Revision: 254150 > URL: http://svnweb.freebsd.org/changeset/base/254150 > > Log: > Add missing 'VPO_BUSY' from r254141 to fix kernel build break. > > Modified: > head/sys/vm/vm_page.h This can't possibly be correct as r254138 just removed this flag. If it isn't obvious how to fix the uses added back in r254141, then r254141 should be reverted instead. Hmm, looking at the relevant bits of r254141, it doesn't look obvious: + /* Detach the old page from the resident tailq. */ + TAILQ_REMOVE(&object->memq, mold, listq); + vm_page_lock(mold); + if (mold->oflags & VPO_BUSY) { + mold->oflags &= ~VPO_BUSY; + vm_page_flash(mold); + } Since nothing is setting this flag, this can't possibly work correctly currently. I wouldn't boot a top-of-tree kernel right now. :( -- John Baldwin --Boundary-00=_VsUBSGAELqL+1H/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201308091603.33445.jhb>