Date: Sun, 17 Aug 1997 07:10:01 -0700 (PDT) From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs Subject: Re: bin/4314: games/boggle Makefile correction Message-ID: <199708171410.HAA29629@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/4314; it has been noted by GNATS.
From: Bruce Evans <bde@zeta.org.au>
To: FreeBSD-gnats-submit@FreeBSD.ORG, nnd@nnd.itfs.nsk.su
Cc: Subject: Re: bin/4314: games/boggle Makefile correction
Date: Sun, 17 Aug 1997 23:58:22 +1000
> Makefile for src/games/boggle incorrectly lists
>data files ('dictionary' and 'dictindex') as a source for
>'all' target, whereas they obviously are the sources for
>'beforeinstall' target already used in this Makefile.
No, 'dictionary' and 'dictindex' are certainly sources for
the 'all' target, and 'install' targets including 'beforeinstall'
should never have sources, since sources for them (and not for
'all') would result in things being built at install time.
> Moreover if you try to do:
>
> cd src/games/boggle
> make obj clean cleandepend depend
> make -j12 all
>
>this will results in error.
You shouldn't expect 'make obj clean cleandepend depend' to work in general.
If the obj directory doesn't already exist, then ${.OBJDIR} is "." the
first time this is run, and .depend is created in ".".
'make -j12' fails because ${MKDICT} is not a source for 'dictionary'.
'::' doesn't work right here (it is used just to keep ${MKDIR} out of
${.ALLSRC} . This use is completely wrong - '::' is good for accumulating
actions but bad for accumulating sources).
>>Fix:
>
> Apply the next patch:
Not a fix.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199708171410.HAA29629>