Date: Sat, 24 Jan 2004 10:06:11 +0000 From: Matthew Seaman <m.seaman@infracaninophile.co.uk> To: Sepherosa Ziehau <sepherosa@SoftHome.net> Cc: "ports@FreeBSD.org" <ports@FreeBSD.org> Subject: Re: FreeBSD Port: jfreechart-0.9.13 Message-ID: <20040124100611.GA66769@happy-idiot-talk.infracaninophile.co.uk> In-Reply-To: <opr187nsrtt45q1u@mail.SoftHome.net> References: <opr177g61vt45q1u@mail.SoftHome.net> <20040123123924.GA49081@happy-idiot-talk.infracaninophile.co.uk> <opr187nsrtt45q1u@mail.SoftHome.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--qMm9M+Fa2AknHoGS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Jan 24, 2004 at 08:29:42AM +0800, Sepherosa Ziehau wrote:
> On Fri, 23 Jan 2004 12:39:24 +0000, Matthew Seaman=20
> <m.seaman@infracaninophile.co.uk> wrote:
> >On Fri, Jan 23, 2004 at 07:28:08PM +0800, Sepherosa Ziehau wrote:
> >>without a java document, a java library is useless. I have upgraded
> >>jfreechart to 0.9.16 and add javadoc support.
> >>Hope somebody can review it and commit it for me.
> >Nice work. However, I can see a couple of problems with your patch.
[..deletia...]
> Thank you for your advice, and the nice mysql-connector.
> I regenerated the patch according to your advice.
> Please review it.
Looks good. However, PORTDOCS and installing port ducmentation should
be conditional on NOPORTDOCS not being defined.
Can you submit these changes via send-pr, which is the official
channel for getting such things committed? You might want to consider
taking over maintainership for this port.
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil. 26 The Paddocks
Savill Way
PGP: http://www.infracaninophile.co.uk/pgpkey Marlow
Tel: +44 1628 476614 Bucks., SL7 1TH UK
--qMm9M+Fa2AknHoGS
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAEkOTdtESqEQa7a0RAn+vAJ9tfJE4UBCEaiu7/Zc/9AWllRoy+QCeM9cb
mQ0uAGqRwZwR6m6Q5Od1fvE=
=/vlm
-----END PGP SIGNATURE-----
--qMm9M+Fa2AknHoGS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040124100611.GA66769>