Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Jul 2013 17:09:49 +0200
From:      Jilles Tjoelker <jilles@stack.nl>
To:        Andrey Zonov <zont@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r253662 - in head: lib/libc/gen sys/vm tools/tools/sysdoc
Message-ID:  <20130726150949.GC14175@stack.nl>
In-Reply-To: <201307260200.r6Q207cB015223@svn.freebsd.org>
References:  <201307260200.r6Q207cB015223@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 26, 2013 at 02:00:07AM +0000, Andrey Zonov wrote:
> Author: zont
> Date: Fri Jul 26 02:00:06 2013
> New Revision: 253662
> URL: http://svnweb.freebsd.org/changeset/base/253662

> Log:
>   Remove define and documentation for vm_pageout_algorithm missed in r253587

> Modified:
>   head/lib/libc/gen/sysctl.3
>   head/sys/vm/vm_param.h
>   head/tools/tools/sysdoc/tunables.mdoc

> Modified: head/sys/vm/vm_param.h
> ==============================================================================
> --- head/sys/vm/vm_param.h	Fri Jul 26 00:28:19 2013	(r253661)
> +++ head/sys/vm/vm_param.h	Fri Jul 26 02:00:06 2013	(r253662)
> @@ -82,9 +82,8 @@
>  #define	VM_V_CACHE_MIN		7	/* cnt.v_cache_min */
>  #define	VM_V_CACHE_MAX		8	/* cnt.v_cache_max */
>  #define VM_V_PAGEOUT_FREE_MIN	9	/* cnt.v_pageout_free_min */
> -#define	VM_PAGEOUT_ALGORITHM	10	/* pageout algorithm */
> -#define VM_SWAPPING_ENABLED	11	/* swapping enabled */
> -#define	VM_MAXID		12	/* number of valid vm ids */
> +#define VM_SWAPPING_ENABLED	10	/* swapping enabled */
> +#define	VM_MAXID		11	/* number of valid vm ids */

As noted in mail from Bruce Evans, please preserve the ABI of
VM_SWAPPING_ENABLED here.

>  #define CTL_VM_NAMES { \
>  	{ 0, 0 }, \
> @@ -97,7 +96,6 @@
>  	{ "v_cache_min", CTLTYPE_UINT }, \
>  	{ "v_cache_max", CTLTYPE_UINT }, \
>  	{ "v_pageout_free_min", CTLTYPE_UINT}, \
> -	{ "pageout_algorithm", CTLTYPE_INT}, \
>  	{ "swap_enabled", CTLTYPE_INT},\
>  }

This should be replaced with some sort of dummy rather than replaced
entirely (does not matter very much because it should not be used).

-- 
Jilles Tjoelker



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130726150949.GC14175>