Date: Wed, 28 Dec 2022 16:38:26 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: "David E. O'Brien" <obrien@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 43dc1409c139 - main - Restricting xargs to '-n1' is much slower and isn't needed for file(1) Message-ID: <4FFD9D6C-48D1-490F-859B-D7579B7BF80E@gmail.com> In-Reply-To: <202212282356.2BSNu41x040983@gitrepo.freebsd.org> References: <202212282356.2BSNu41x040983@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 28, 2022, at 15:56, David E. O'Brien <obrien@freebsd.org> wrote: > > The branch main has been updated by obrien: > > URL: https://cgit.FreeBSD.org/src/commit/?id=43dc1409c139c39056bafdcd4d083230ccb10b50 > > commit 43dc1409c139c39056bafdcd4d083230ccb10b50 > Author: David E. O'Brien <obrien@FreeBSD.org> > AuthorDate: 2022-12-28 23:49:21 +0000 > Commit: David E. O'Brien <obrien@FreeBSD.org> > CommitDate: 2022-12-28 23:54:29 +0000 > > Restricting xargs to '-n1' is much slower and isn't needed for file(1) > > Also note that libc.so.6 is an older version of libc (thus why you'd > want to find files linked against it). > --- > usr.bin/ldd/ldd.1 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/usr.bin/ldd/ldd.1 b/usr.bin/ldd/ldd.1 > index d263eabcf4ff..47a7fff9f778 100644 > --- a/usr.bin/ldd/ldd.1 > +++ b/usr.bin/ldd/ldd.1 > @@ -59,8 +59,8 @@ The following is an example of a shell pipeline which uses the > .Fl f > option. > It will print a report of all ELF binaries in the current directory, > -which link against libc.so.6: > -.Dl "find . -type f | xargs -n1 file -F ' ' | grep 'ELF.*dynamically' | cut -f1 -d' ' | xargs ldd -f '%A %o\en' | grep libc.so.6" > +which link against the old libc.so.6: > +.Dl "find . -type f | xargs file -F ' ' | grep 'ELF.*dynamically' | cut -f1 -d' ' | xargs ldd -f '%A %o\en' | grep -F libc.so.6" > .Sh SEE ALSO > .Xr ld 1 , > .Xr nm 1 , Hi David, The commit message doesn’t match the change: the ldd man page was changed in this commit. Take care! -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FFD9D6C-48D1-490F-859B-D7579B7BF80E>