Date: Fri, 11 Jan 2019 11:16:38 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Devin Teske <dteske@FreeBSD.org> Cc: rgrimes@FreeBSD.org, Warner Losh <imp@bsdimp.com>, Lars Engels <lme@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config Message-ID: <201901111916.x0BJGcLG022599@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <A5C8049C-DB95-4EBC-965E-A4DD399EF020@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > On Jan 11, 2019, at 10:36 AM, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > > > >> On Fri, Jan 11, 2019 at 10:10 AM Rodney W. Grimes < > >> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > >> > >>>> On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: > >>>>> The style of this .sh does not match the normal style of > >>>>> such things in base, especially with respect to long lines > >>>>> and indentation. > >>>> > >>>> Do we have a style guide for shell scripts in base? How should > >>>> indentation look like? > >>> > >>> Not that I can locate, but I can state that almost all > >>> of the base code uses tab indenting and limited to 80 > >>> column widths, independent of c, sh, make, etc. > >>> > >> > >> We have a style.Makefile, style, style.mdoc and style.lua man pages. Maybe > >> it's time for style.sh, eh? > > > > Yes please! > > > > If we can agree to be professional and collegial, ... > > I'll start with chapters from the Style section of my book: > https://freebsdfrau.gitbooks.io/serious-shell-programming/content/style/awk.html > <https://freebsdfrau.gitbooks.io/serious-shell-programming/content/style/awk.html>; If you can mdoc that and take what applies to /bin/sh. Might be easier to start with one of the other style.foo pages though. And we don't want to go to far and put all of our sh code out of conformance. For one variable being $foo or ${foo} is varied greatly, IMHO the rule should be that the file just be consistent through out, and that one or the other is the prefered style, but either is acceptable. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901111916.x0BJGcLG022599>