Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Sep 2024 21:50:55 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 5681ddfd9f80 - main - msi_alloc(): do not leak msi_lock in error case
Message-ID:  <202409042150.484LotVO033157@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=5681ddfd9f80c3aa25f900a1bcaa69b36a4e9e27

commit 5681ddfd9f80c3aa25f900a1bcaa69b36a4e9e27
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2024-08-27 02:28:10 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2024-09-04 21:50:19 +0000

    msi_alloc(): do not leak msi_lock in error case
    
    Sponsored by:   Advanced Micro Devices (AMD)
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
---
 sys/x86/x86/msi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/x86/x86/msi.c b/sys/x86/x86/msi.c
index 888635cba3f4..177bd7868ec4 100644
--- a/sys/x86/x86/msi.c
+++ b/sys/x86/x86/msi.c
@@ -480,6 +480,7 @@ again:
 	if (error != 0) {
 		for (i = 0; i < count; i++)
 			apic_free_vector(cpu, vector + i, irqs[i]);
+		mtx_unlock(&msi_lock);
 		free(mirqs, M_MSI);
 		return (error);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202409042150.484LotVO033157>