Date: Wed, 30 May 2018 08:10:15 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Ed Maste <emaste@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334363 - head/usr.bin/elfdump Message-ID: <20180530121015.mpdt6gh45kyriciv@mutt-hbsd> In-Reply-To: <201805300116.w4U1GoWj090163@repo.freebsd.org> References: <201805300116.w4U1GoWj090163@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--pufr72ltxxoexor4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 30, 2018 at 01:16:50AM +0000, Ed Maste wrote: > Author: emaste > Date: Wed May 30 01:16:50 2018 > New Revision: 334363 > URL: https://svnweb.freebsd.org/changeset/base/334363 >=20 > Log: > elfdump: chase ABI tag note name change from r232832 > =20 > r232832 changed the ABI tag note name from .note.ABI-tag to .note.tag. > Follow suit in elfdump. > =20 > Elfdump's note parsing is very basic and should be significantly > reworked, but for now just restore the broken functionality. > =20 > PR: 228290 > Submitted by: martin at lispworks.com > MFC after: 1 week >=20 > Modified: > head/usr.bin/elfdump/elfdump.c >=20 > Modified: head/usr.bin/elfdump/elfdump.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/elfdump/elfdump.c Wed May 30 00:36:58 2018 (r334362) > +++ head/usr.bin/elfdump/elfdump.c Wed May 30 01:16:50 2018 (r334363) > @@ -659,7 +659,7 @@ main(int ac, char **av) > case SHT_NOTE: > name =3D elf_get_word(e, v, SH_NAME); > if (flags & ED_NOTE && > - strcmp(shstrtab + name, ".note.ABI-tag") =3D=3D 0) > + strcmp(shstrtab + name, ".note.tag") =3D=3D 0) > elf_print_note(e, v); > break; > case SHT_DYNSYM: I wonder if it would be a good idea to handle .note.ABI-tag and =2Enote.tag so that it can handle binaries compiled both before and after r232832. Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --pufr72ltxxoexor4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlsOlKIACgkQaoRlj1JF bu7+kA//aDsIerZl0f8HRNtCWMNTWEYlZP2JLnXJNaj+pvdvwgWfsQmXfshh4qQQ 5p6yFoUMNhRJu8fs+yc6Fy9zPFezmjrvYn/Lk4rwf4gGsIAIeXEs14kGu6+Qbc01 6UKY+4wBfE+aaCne7IM/Uq8Uh9IaRm612p37rTTYRIXCgpND3ml2i2YI/SZ0Aixt Jhk98i+bmvmOlCTtQuN3+QqPK0RUwXZFeIK6PPG22IBxsQu1ZH9TBFt71Cka1PyM +gtCmPEwqgQYUNySLCBEJPJXWt90H02fXM96bEpSQnKhKRCnCtMHQOCJc5vTgF+u xuQRhgoluJMmfjIGYQyZbpyPxXotVABpCTTPux9B8pxAGiPdfehFsSH+CgXmJIT8 VAvkpFwZ54QcO8fJP1+dn7RcxOSRNw1eOe1oFWHmkqRL4hBwgI7ti5xj8ONZmJFr uJf6JPadYTf+TGneAX+EGe4YgwU6pV3Yn+wCLdidTIworqrdlq43JeIyF+sHH6vW xbfy8FhnCT96ajyKFFQ1TnW/NtxBuKqIZOYgU04YL0W13t8K6xSaDfNaF8+dm2fs msetTZD77pNMQpF6Zj69D6MmPH9zboX0fARRgbvIXIy1tw5zB8tCCwn8VIA6GzOU +gK3MnWkfwOqwx6XkSurfsEI4hoMeviSdhtK7UuAR5EKYdx3F9A= =z9T0 -----END PGP SIGNATURE----- --pufr72ltxxoexor4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180530121015.mpdt6gh45kyriciv>