Date: Mon, 8 Nov 2010 12:11:42 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r214961 - head/usr.bin/yacc Message-ID: <20101108201142.GB90846@dragon.NUXI.org> In-Reply-To: <AANLkTi=zKy%2B%2Bq2DLreKR6Gt4ykTKfjymO7f47pG-jH0A@mail.gmail.com> References: <201011072322.oA7NMhb0092364@svn.freebsd.org> <AANLkTi=zKy%2B%2Bq2DLreKR6Gt4ykTKfjymO7f47pG-jH0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 07, 2010 at 05:54:20PM -0800, Juli Mallett wrote: > On Sun, Nov 7, 2010 at 15:22, David E. O'Brien <obrien@freebsd.org> wrote: > > Author: obrien > > Date: Sun Nov 7 23:22:42 2010 > > New Revision: 214961 > > URL: http://svn.freebsd.org/changeset/base/214961 > > > > Log: > > Directly use memory allocation functions and remove needless casts in > > their usage. Also use associated modern types instead of k&r ones. > > You do know that changing skeleton.c affects the generated files, > right? Yes Juli, I know how byacc works. > I'm wondering if whatever sed script you're > judiciously-applying knows that. C++ does not do implicit conversions > from "void *" so you need the casts on the mallocs there. The changes I made were tested on building several other applications. > With a C++ compiler: But as you indirectly point out -- they were all C applications. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101108201142.GB90846>