Date: Mon, 21 Oct 2024 18:18:23 +0000 (UTC) From: Pedro Giffuni <pfg@freebsd.org> To: "maxim@freebsd.org" <maxim@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: b88df1e893c4 - main - Reapply "sbin/ping: allow normal users to specify larger packets" Message-ID: <1791968192.4471640.1729534703845@mail.yahoo.com> In-Reply-To: <39113afb-66e8-da08-14ab-83564c1271b2@maxim.int.ru> References: <202410161840.49GIe8CR000407@gitrepo.freebsd.org> <f0575f7e-e155-85a7-fa7c-5a67af27ef63@maxim.int.ru> <39113afb-66e8-da08-14ab-83564c1271b2@maxim.int.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Sorry ...
I completely missed this was causing any trouble. My filters threw the reply into a folder that I don't look at regularly.
Thanks to markj@ for backing it out.
Pedro.
On Friday, October 18, 2024 at 02:41:12 PM GMT-5, maxim@freebsd.org <maxim@freebsd.org> wrote:
Hi Pedro,
Unless you have a plan to address this issue please backout this code
as it is clearly wrong.
Thanks,
Maxim
On Wed, 16 Oct 2024, 19:04-0000, Maxim Konovalov wrote:
> Hi Pedro,
>
> No, this is not right. Let me clarify:
>
> (1) I never told that there are any issues with the tests. I just
> mumbled that the tests should catch such regression though I never
> checked if they actually did.
>
> (2) The MAXPAYLOAD calculation in the code below is not fully correct.
>
> It should be
>
> 65535 - 20 (ip header) - 8 (icmp part) = 65507 without IP options
>
> OR
>
> 65535 - 20 (ip header) - 40 (ip options) - 8 (icmp part) = 65467 with
> IP options, ie. whenever you run ping -R.
>
> The code below hardcoded the latter value which is simply wrong.
>
> I wouldn't rely on the fact that you get it from other BSD flavours
> and would recommend to have this code reviewed before committing it.
>
> Maxim
>
--
Maxim Konovalov
[-- Attachment #2 --]
<html><head></head><body><div class="ydp3b5014f4yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;"><div></div>
<div dir="ltr" data-setdir="false">Sorry ...</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">I completely missed this was causing any trouble. My filters threw the reply into a folder that I don't look at regularly.</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">Thanks to markj@ for backing it out. </div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">Pedro.</div><div><br></div>
</div><div id="ydpd8cf4408yahoo_quoted_9936507121" class="ydpd8cf4408yahoo_quoted">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
On Friday, October 18, 2024 at 02:41:12 PM GMT-5, maxim@freebsd.org <maxim@freebsd.org> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div dir="ltr">Hi Pedro,<br clear="none"><br clear="none">Unless you have a plan to address this issue please backout this code<br clear="none">as it is clearly wrong.<br clear="none"><br clear="none">Thanks,<br clear="none"><br clear="none">Maxim<br clear="none"><div class="ydpd8cf4408yqt2348932468" id="ydpd8cf4408yqtfd32071"><br clear="none">On Wed, 16 Oct 2024, 19:04-0000, Maxim Konovalov wrote:<br clear="none"><br clear="none">> Hi Pedro,<br clear="none">><br clear="none">> No, this is not right. Let me clarify:<br clear="none">><br clear="none">> (1) I never told that there are any issues with the tests. I just<br clear="none">> mumbled that the tests should catch such regression though I never<br clear="none">> checked if they actually did.<br clear="none">><br clear="none">> (2) The MAXPAYLOAD calculation in the code below is not fully correct.<br clear="none">><br clear="none">> It should be<br clear="none">><br clear="none">> 65535 - 20 (ip header) - 8 (icmp part) = 65507 without IP options<br clear="none">><br clear="none">> OR<br clear="none">><br clear="none">> 65535 - 20 (ip header) - 40 (ip options) - 8 (icmp part) = 65467 with<br clear="none">> IP options, ie. whenever you run ping -R.<br clear="none">><br clear="none">> The code below hardcoded the latter value which is simply wrong.<br clear="none">><br clear="none">> I wouldn't rely on the fact that you get it from other BSD flavours<br clear="none">> and would recommend to have this code reviewed before committing it.<br clear="none">><br clear="none">> Maxim<br clear="none">><br clear="none"><br clear="none">-- <br clear="none">Maxim Konovalov<br clear="none"></div></div></div>
</div>
</div></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1791968192.4471640.1729534703845>