Date: Sat, 11 Feb 2017 10:12:07 +0100 From: Ed Schouten <ed@nuxi.nl> To: Ngie Cooper <ngie@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r313632 - in stable/10/contrib/netbsd-tests/lib/libc/gen: . posix_spawn Message-ID: <CABh_MKmYuP-Yb3VLJ3EOb1dODtHmN8uoSuytTrjTQm=C9iwuMw@mail.gmail.com> In-Reply-To: <201702110735.v1B7ZROH028648@repo.freebsd.org> References: <201702110735.v1B7ZROH028648@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2017-02-11 8:35 GMT+01:00 Ngie Cooper <ngie@freebsd.org>:
> Note that sys/types.h is required on FreeBSD for kqueue(2), unlike NetBSD
Which is a bug on its own in my opinion. What do you think of this patch?
Index: sys/sys/event.h
===================================================================
--- sys/sys/event.h (revision 313335)
+++ sys/sys/event.h (working copy)
@@ -29,7 +29,8 @@
#ifndef _SYS_EVENT_H_
#define _SYS_EVENT_H_
-#include <sys/queue.h>
+#include <sys/_types.h>
+#include <sys/queue.h>
#define EVFILT_READ (-1)
#define EVFILT_WRITE (-2)
@@ -57,11 +58,11 @@
} while(0)
struct kevent {
- uintptr_t ident; /* identifier for this event */
+ __uintptr_t ident; /* identifier for this event */
short filter; /* filter for event */
- u_short flags;
- u_int fflags;
- intptr_t data;
+ unsigned short flags;
+ unsigned int fflags;
+ __intptr_t data;
void *udata; /* opaque user data identifier */
};
--
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKmYuP-Yb3VLJ3EOb1dODtHmN8uoSuytTrjTQm=C9iwuMw>