Date: Thu, 30 May 2002 23:29:44 -0700 (PDT) From: Julian Elischer <julian@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 12185 for review Message-ID: <200205310629.g4V6TiO32911@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12185 Change 12185 by julian@julian_ref on 2002/05/30 23:29:36 compiles now, but would be better if there was a fpointer() and fpointer() (like suword() etc.) Affected files ... ... //depot/projects/kse/sys/i386/i386/trap.c#45 edit ... //depot/projects/kse/sys/kern/kern_thread.c#51 edit ... //depot/projects/kse/sys/kern/subr_trap.c#59 edit Differences ... ==== //depot/projects/kse/sys/i386/i386/trap.c#45 (text+ko) ==== @@ -955,8 +955,8 @@ * possibility that we could do this lazily (in sleep()), * but for now do it every time. */ - td->td_mailbox = fuword((caddr_t)td->td_kse->ke_mailbox + - offsetof(struct kse_mailbox, current_thread)); + td->td_mailbox = (void *)fuword((caddr_t)td->td_kse->ke_mailbox + + offsetof(struct kse_mailbox, current_thread)); if ((td->td_mailbox == NULL) || (td->td_mailbox == (void *)-1)) { td->td_mailbox = NULL; /* single thread it.. */ ==== //depot/projects/kse/sys/kern/kern_thread.c#51 (text+ko) ==== @@ -265,12 +265,13 @@ addr2 = (caddr_t)td->td_mailbox + offsetof(struct thread_mailbox , next_completed); /* Then link it into it's KSE's list of completed threads. */ - if (!error) + if (!error) { error = td2_mbx = fuword(addr1); if (error == -1) error = EFAULT; else error = 0; + } if (!error) error = suword(addr2, td2_mbx); if (!error) ==== //depot/projects/kse/sys/kern/subr_trap.c#59 (text+ko) ==== @@ -199,7 +199,6 @@ * This is NOT just an 'else' clause for the above test... */ if (td->td_flags & TDF_UPCALLING) { - void *dummy = NULL; CTR3(KTR_PROC, "userret: upcall thread %p (pid %d, %s)", td, p->p_pid, p->p_comm); /* To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205310629.g4V6TiO32911>