Date: Sat, 24 Apr 2004 08:19:39 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Mike Makonnen <mtm@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/thread thr_spinlock.c Message-ID: <20040424151939.GC78817@elvis.mu.org> In-Reply-To: <200404240938.i3O9cgCB044808@repoman.freebsd.org> References: <200404240938.i3O9cgCB044808@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Mike Makonnen <mtm@FreeBSD.org> [040424 02:38] wrote: > mtm 2004/04/24 02:38:42 PDT > > FreeBSD src repository > > Modified files: > lib/libthr/thread thr_spinlock.c > Log: > Unconditionaly initialize any spin lock passed to pthread_spin_init(). While > makeing sure the spinlock isn't already in use might be a nice feature to > have in theory, it's hard to implement in practice since the passed in > pointer may not be NULL, but still be an invalid value (i.e. 1..2..3.. etc). Good call. Forcing it to be NULL and it might as already be initialized. :) (*looks at our kernel API and grumbles*) > > Revision Changes Path > 1.10 +0 -4 src/lib/libthr/thread/thr_spinlock.c -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040424151939.GC78817>