Date: Thu, 18 Oct 2007 04:31:29 GMT From: John Birrell <jb@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 127654 for review Message-ID: <200710180431.l9I4VTCw094077@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=127654 Change 127654 by jb@jb_freebsd1 on 2007/10/18 04:31:18 The FreeBSD kernel has note sections which aren't 4-byte aligned. I see that tools on other systems assume that notes have byte alignment even though the natural alignment would be 4 bytes given that's the size of the first field in the notes header. We have to be compatible though, so byte alignment it must be. Affected files ... .. //depot/projects/dtrace/src/lib/libelf/libelf_align.c#5 edit Differences ... ==== //depot/projects/dtrace/src/lib/libelf/libelf_align.c#5 (text+ko) ==== @@ -122,7 +122,7 @@ #endif [ELF_T_MOVEP] = UNSUPPORTED(), #if __FreeBSD_version >= 700025 - [ELF_T_NOTE] = FALIGN(4,4), + [ELF_T_NOTE] = FALIGN(1,1), #endif [ELF_T_OFF] = FALIGN(4,8), [ELF_T_PHDR] = FALIGN(4,8),
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710180431.l9I4VTCw094077>