Date: Tue, 22 Nov 2016 12:33:50 -0800 From: Stephen Hurd <shurd@sasktel.net> To: cem@freebsd.org, Stephen Hurd <shurd@freebsd.org>, Stephen Hurd <stephen.hurd@broadcom.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308696 - in head: share/man/man4 sys/boot/forth sys/conf sys/dev/bnxt sys/modules sys/modules/bnxt Message-ID: <5834ABAE.50802@sasktel.net> In-Reply-To: <CAG6CVpVgUaBB_U%2BjMvee2E2XrjKxorhrTmVMMtZQrSvpypthQQ@mail.gmail.com> References: <201611152035.uAFKZTQB045021@repo.freebsd.org> <CAG6CVpVgUaBB_U%2BjMvee2E2XrjKxorhrTmVMMtZQrSvpypthQQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Conrad Meyer wrote: > Hi Stephen, > > Coverity reports a missing 'break;' (or explicit /* FALLTHROUGH */) in > if_bnxt.c:1915. (The HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASEKR cases > flow into the HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASELR case.) CID is > 1366223. > > If the fall-through is intentional, please add the comment. If it > isn't, I guess it needs a break statement. > > Thanks, > Conrad Yes, that needs the break. I'll get that in today.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5834ABAE.50802>