Date: Tue, 16 Jul 2002 05:33:42 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Alfred Perlstein <alfred@FreeBSD.org> Cc: Dag-Erling Smorgrav <des@ofug.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/usr.bin/tail Makefile tail.c Message-ID: <20020716052659.G41739-100000@gamplex.bde.org> In-Reply-To: <20020715105432.GJ77219@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 15 Jul 2002, Alfred Perlstein wrote:
> * Bruce Evans <bde@zeta.org.au> [020715 03:27] wrote:
> > On Mon, 15 Jul 2002, Alfred Perlstein wrote:
> >
> > > Er, both size_t and off_t are pretty much the same one i386 and alpha...
> >
> > Actually, the are quite different.
>
> BUHHH...
>
> size_t is 64 bits on alpha (versus 32 on i386), isn't it?
Yes.
> > > Also, casting enomem of line 257 of reverse.c doesn't fix this warning
> > > which makes no sense...
> > >
> > > Index: reverse.c
> > > - warnx("warning: %qd bytes discarded", enomem);
> > > + warnx("warning: %qd bytes discarded", (quad_t)enomem);
> >
> > This makes sense. %qd is just an alias for %lld, so it unsuitable for
> > printing anything except long longs. Neither off_t nor quad_t is long
> > long on alphas.
>
> That's just obnoxious. :)
>
> Any chance you can suggest how to clean this up? The fact that we
> can't compile tail(1) without warnings bugs me.
Just cast off_t's to intmax_t and print them using %jd. The correct way
to print most other foo_t's is not so clear. %j[du...] is overkill for
most of them, but might become necessary.
I won't clean up anything related to quad_t's since I want them to go away :-).
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020716052659.G41739-100000>