Date: Tue, 11 Mar 2014 17:33:33 -0400 From: Ryan Stone <rysto32@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: [PATCH] Add MSI support to puc(9) Message-ID: <CAFMmRNy5QS8oCjeQbjWbvy=Q3DNTqi6bTMWBcyCnULe6DgSV1A@mail.gmail.com> In-Reply-To: <201403111722.31559.jhb@freebsd.org> References: <CAFMmRNy9EG3byRV1b=4W5MejMiAz8yV6UnnEMjcJmY-FyMj2sg@mail.gmail.com> <201402271330.02699.jhb@freebsd.org> <CAFMmRNw-pKOczNyNwi5jhJEKW=sYeGe8DB5URGT=B-Z-prOe0w@mail.gmail.com> <201403111722.31559.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 11, 2014 at 5:22 PM, John Baldwin <jhb@freebsd.org> wrote:
> This generally looks good, but I don't really like abusing sc_irid as the
> count parameter. I would use a standalone count and only set sc_irid to 1 if
> it works:
>
> count = 1;
> if (pci_alloc_msi(dev, &count) == 0) {
> sc->sc_msi = 1;
> sc->sc_irid = 1;
> }
I've updated the patch again. I should be able to test it on hardware
with MSI support tomorrow morning.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNy5QS8oCjeQbjWbvy=Q3DNTqi6bTMWBcyCnULe6DgSV1A>