Date: Fri, 26 Oct 2007 13:21:38 -0600 From: Scott Long <scottl@samsco.org> To: Andrey Chernov <ache@nagual.pp.ru>, Rong-en Fan <grafan@gmail.com>, Scott Long <scottl@samsco.org>, John Baldwin <jhb@freebsd.org>, src-committers@freebsd.org, d@delphij.net, cvs-all@freebsd.org, Robert Watson <rwatson@freebsd.org>, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/locale utf8.c Message-ID: <47223E42.4090905@samsco.org> In-Reply-To: <20071026190039.GB38843@nagual.pp.ru> References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <20071025233536.B99770@fledge.watson.org> <472120E8.90504@samsco.org> <200710261144.34645.jhb@freebsd.org> <472217C2.8020800@samsco.org> <6eb82e0710260954m73b3f17bq2c72a4cdb597640e@mail.gmail.com> <20071026190039.GB38843@nagual.pp.ru>
index | next in thread | previous in thread | raw e-mail
Andrey Chernov wrote: > On Sat, Oct 27, 2007 at 12:54:21AM +0800, Rong-en Fan wrote: >> As for RELENG_7 and HEAD, I'm not 100% sure whether we should restore >> the compatibility as 1) 7.0 is not released yet, 2) we don't promise >> anything in >> HEAD branch. However, if most people think get rid of inline stuffs and >> have libc compatibility are nice, then we do the same for those two branches. > > Although standard permits functions only, I object against permanent > removing inlines from ctype. Almost every system have them as macros or > inlines and not as function calls, and it is for reason. Ctype functions > are very inside-loop-intensive, and not speeding them up may slowdown apps > which do intensive text processing. > > In the case we trade forward compatibility for speed for 6x, may be, I > don't have opinion here. > RELENG_6 is what I'm most concerned about, so thank you for compromising on it. It's unfortunate that turmoil was created in HEAD and RELENG_7, but it looks like it was unavoidable given our standard practices of MFC oriented changes. I do think that this all could have been planned and executed better so that surprises and changes like this weren't needed. But, live and learn. Thanks for working on it. Scotthome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47223E42.4090905>