Date: Fri, 26 Mar 2021 21:05:53 +0000 From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 254577] [PATCH] pf: Implement the NAT source port selection of MAP-E Customer Edge Message-ID: <bug-254577-16861-D9HZ36d55O@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-254577-16861@https.bugs.freebsd.org/bugzilla/> References: <bug-254577-16861@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254577 --- Comment #1 from Kristof Provost <kp@freebsd.org> --- I need to read up on MAP-E before I can say much sensible, but on first gla= nce this looks like a pretty solid patch. It appears to date from before the split-up of pf_pool / pf_kpool, but that= 's a minor issue. A somewhat bigger issue is that it changes the definition of pf_pool, which means that it breaks the userspace API. That's pretty much inevitable when adding new functionality, but it's still problematic. I'm currently working on introducing nvlist based alternatives, which would= fix that problem. Right now only DIOCADDRULE/DIOCGETRULE, but that's most of wh= at's needed here. I'll try to push that work somewhere when it's closer to being usable. Hopefully in a week or two. In the mean time it'd also be nice to have a test or two for this. Even if = all it does is configure the functionality and run a few packets through it. (M= ore is better, of course). There are a number of example tests in /usr/src/tests/sys/netpfil/pf. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-254577-16861-D9HZ36d55O>