Date: Mon, 19 Nov 2018 11:36:38 -0500 From: Ed Maste <emaste@freebsd.org> To: Mariusz Zaborski <oshogbo@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340363 - in head: . contrib/tcpdump contrib/traceroute lib/libcasper/services/cap_dns lib/libcasper/services/cap_dns/tests sbin/ping Message-ID: <CAPyFy2BwrV6HsV1kBSo%2BbXDyM08KUbg1eAyez4LXwCagmoLVPg@mail.gmail.com> In-Reply-To: <201811121552.wACFqjLr002955@repo.freebsd.org> References: <201811121552.wACFqjLr002955@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 12 Nov 2018 at 10:53, Mariusz Zaborski <oshogbo@freebsd.org> wrote: > > Author: oshogbo > Date: Mon Nov 12 15:52:45 2018 > New Revision: 340363 > URL: https://svnweb.freebsd.org/changeset/base/340363 > > Log: > libcasper: [ch]ange the name of limits in cap_dns so the intentions are obvious. Mariusz and I discussed this on IRC but for the sake of the archives this breaks applications with existing calls to cap_dns_type_limit using the old names - e.g., upstream tcpdump. As tcpdump is the only out-of-tree consumer of cap_dns_type_limit that I'm aware of we could probably fix this by submitting a patch to tcpdump to add a configure test or a __FreeBSD_version conditional. However, it seems easiest to just allow either string in cap_dns.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BwrV6HsV1kBSo%2BbXDyM08KUbg1eAyez4LXwCagmoLVPg>