Date: Tue, 25 Sep 2012 15:46:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Chris Rees <utisoft@gmail.com> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r304840 - in head/x11: nvidia-driver nvidia-driver-173 nvidia-driver-71 nvidia-driver-96 Message-ID: <20120925154652.GA18222@FreeBSD.org> In-Reply-To: <CADLo83-eY64UQXpHHER87GK7=bQzyd5D5qKtybiZEUCcRoFZ_w@mail.gmail.com> References: <201209251523.q8PFNFwb051770@svn.freebsd.org> <CADLo83-eY64UQXpHHER87GK7=bQzyd5D5qKtybiZEUCcRoFZ_w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 25, 2012 at 04:32:06PM +0100, Chris Rees wrote: > I don't know if a special comment is needed; this is pretty standard slave > behaviour. I'd rather keep it, as nvidia-driver is pretty complicated port(s), and I want it (them) to be documented thoroughly. Almost all patches people send to me miss one or two little things like that. :-( > However, it is a common problem, perhaps we could put a note into the > Porter's Handbook in PORTREVISION or master/slave sections? > > "It is usually incorrect to set PORTREVISION to 0, except in a slave port > where it should override the master port" I would change the last part to "where it should override the one set in the master port". ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120925154652.GA18222>