Date: Tue, 16 Sep 2014 08:01:45 +0200 From: Thomas Zander <riggs@freebsd.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r368267 - head/math/gotoblas Message-ID: <CAFU734zqVspP9G=9oJYe3xZ0oL1rOhiZyx0tyOpWJX3tww8zpQ@mail.gmail.com> In-Reply-To: <CAJE75NEaUEUssMRoH=JCAGmEeT%2BrjUunUOAWDnUEpWd=yjuRFA@mail.gmail.com> References: <201409151453.s8FErDCV032464@svn.freebsd.org> <CAJE75NEaUEUssMRoH=JCAGmEeT%2BrjUunUOAWDnUEpWd=yjuRFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 September 2014 02:13, Jason E. Hale <jhale@freebsd.org> wrote:
> I think wrapping OPTIONS_DEFAULT_${ARCH} with ${ARCH} defeats the
> purpose of having OPTIONS_DEFAULT_${ARCH} in the first place.
> Wouldn't simply removing .if defined(PACKAGE_BUILDING)/.endif have
> been enough?
Wrapping is not necessary, you're right. I have removed those.
Removing the PACKAGE_BUILDING would not have been sufficient because
DYNAMIC_ARCH is not supported on machines other than i386 and amd64
and causes build failures there.
Thanks for reporting the issue
Riggs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU734zqVspP9G=9oJYe3xZ0oL1rOhiZyx0tyOpWJX3tww8zpQ>