Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Mar 1999 13:16:25 -0500 (EST)
From:      Brian Feldman <green@unixhelp.org>
To:        Nate Williams <nate@mt.sri.com>
Cc:        John Polstra <jdp@polstra.com>, current@FreeBSD.ORG
Subject:   Re: callout changes nit
Message-ID:  <Pine.BSF.4.05.9903061315390.17793-100000@janus.syracuse.net>
In-Reply-To: <199903061736.KAA24445@mt.sri.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Mar 1999, Nate Williams wrote:

> > > I make a habit of checking out any interesting kernel changes in full, and one
> > > thing I found in the recent diff by Mr. Wollman for kern_timeout.c is:
> > > 
> > > +void
> > > +callout_init(c)
> > > +       struct  callout *c;
> > > +{
> > > +       bzero(c, sizeof c);
> > >  }
> > > 
> > > That doesn't look correct, does it?
> > 
> > Agreed.  I think it should be "sizeof *c".
> 
> Ahh, I see.  I think it should say
> 
>        bzero(c, sizeof(struct callout));
> 
> To avoid the compiler using the size of the pointers et. al.
> 

I prefer to do this in my own code, usually. However, using *c doesn't
"use the size of the pointer".

> 
> Nate
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
> 

 Brian Feldman					  _ __  ___ ___ ___  
 green@unixhelp.org			      _ __ ___ | _ ) __|   \ 
	     http://www.freebsd.org/	 _ __ ___ ____ | _ \__ \ |) |
 FreeBSD: The Power to Serve!	   _ __ ___ ____ _____ |___/___/___/ 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9903061315390.17793-100000>