Date: Wed, 08 Apr 2015 12:24:48 -0400 From: John Baldwin <jhb@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r281188 - head/usr.bin/netstat Message-ID: <6969546.Tk7XnsGrVd@ralph.baldwin.cx> In-Reply-To: <201504070550.t375oklh014315@svn.freebsd.org> References: <201504070550.t375oklh014315@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, April 07, 2015 05:50:46 AM Gleb Smirnoff wrote: > Author: glebius > Date: Tue Apr 7 05:50:45 2015 > New Revision: 281188 > URL: https://svnweb.freebsd.org/changeset/base/281188 > > Log: > Like it was already done for 'netstat -i', drop the kvm(3) support > in 'netstat -r'. > > The netstat/route.c was the last abuser of struct ifnet and struct > rtentry in the tree. With this change if_var.h can become kernel > only include, _WANT_RTENTRY can go away and projects/ifnet and > projects/routing can go forward. > > Differential Revision: https://reviews.freebsd.org/D2242 > Reviewed by: melifaro, gnn > Sponsored by: Nginx, Inc. > Sponsored by: Netflix This breaks netstat -r on a crashdump. Just because you don't find this information useful during post-mortem debugging doesn't mean that other folks do not. The easiest solution is to update crashinfo to remove the netstat commands it runs. However, I don't understand the fear that system binaries can peek inside the kernel for debugging info. It's ok for it to be a fragile ABI that isn't exposed to normal applications and to require people to keep a matching netstat with their kernel (along with the other tools crashinfo calls). Just update the code in netstat to cope with the new data structures. That should be much easier to test than having to convert N device drivers. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6969546.Tk7XnsGrVd>