Date: Fri, 14 Jun 2019 21:36:03 +0000 From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 238563] www/chromium: build failure Message-ID: <bug-238563-28929-fVCcQTSABz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238563-28929@https.bugs.freebsd.org/bugzilla/> References: <bug-238563-28929@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238563 Carlos J. Puga Medina <cpm@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205061|0 |1 is obsolete| | --- Comment #4 from Carlos J. Puga Medina <cpm@freebsd.org> --- (In reply to Konstantin Belousov from comment #3) pthread_get_name_np is supported on 11.2-STABLE. It's added in base/sampling_heap_profiler/sampling_heap_profiler.cc --- base/sampling_heap_profiler/sampling_heap_profiler.cc.orig 2019-06-04 18:55:15 UTC +++ base/sampling_heap_profiler/sampling_heap_profiler.cc @@ -30,6 +30,10 @@ #include <sys/prctl.h> #endif +#if defined(OS_BSD) +#include <pthread_np.h> +#endif + #if defined(OS_ANDROID) && BUILDFLAG(CAN_UNWIND_WITH_CFI_TABLE) && \ defined(OFFICIAL_BUILD) #include "base/trace_event/cfi_backtrace_android.h" @@ -65,6 +69,10 @@ const char* GetAndLeakThreadName() { #elif defined(OS_MACOSX) int err =3D pthread_getname_np(pthread_self(), name, kBufferLen); if (err =3D=3D 0 && *name !=3D '\0') + return strdup(name); +#elif defined(OS_BSD) + pthread_get_name_np(pthread_self(), name, kBufferLen); + if (*name !=3D '\0') return strdup(name); #endif // defined(OS_LINUX) || defined(OS_ANDROID) We're working to unbreak chromium on 11.2-RELEASE. --- Comment #5 from Carlos J. Puga Medina <cpm@freebsd.org> --- Created attachment 205064 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D205064&action= =3Dedit patch Let's take advantage of pthread_get_name_np() only if it's available. Firef= ox applies the same solution. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238563-28929-fVCcQTSABz>