Date: Wed, 28 Oct 2020 16:08:59 +0100 From: Stefan Esser <se@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r367103 - head/usr.bin/calendar Message-ID: <46d724c0-87b8-740c-777d-f699527ccb6e@freebsd.org> In-Reply-To: <CACNAnaHsuz=1=AxdGhr7Z5avhb5J%2BMXKAhPZN_mtvCzbHoXJiA@mail.gmail.com> References: <202010281306.09SD6dgf040611@repo.freebsd.org> <CACNAnaERLh7NvWQ45FZd_s94rApwzyDpah2APP3m=VbfBZrTgg@mail.gmail.com> <784474fd-2f63-066c-eb86-cddfebd499cb@freebsd.org> <CACNAnaHsuz=1=AxdGhr7Z5avhb5J%2BMXKAhPZN_mtvCzbHoXJiA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SraZyjpp1MzbUeqQKnszS3zpdRXMoSNbS Content-Type: multipart/mixed; boundary="P6HVEqyz4GHEQz3uca9XPfa6h6vjHqUJ1"; protected-headers="v1" From: Stefan Esser <se@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Message-ID: <46d724c0-87b8-740c-777d-f699527ccb6e@freebsd.org> Subject: Re: svn commit: r367103 - head/usr.bin/calendar References: <202010281306.09SD6dgf040611@repo.freebsd.org> <CACNAnaERLh7NvWQ45FZd_s94rApwzyDpah2APP3m=VbfBZrTgg@mail.gmail.com> <784474fd-2f63-066c-eb86-cddfebd499cb@freebsd.org> <CACNAnaHsuz=1=AxdGhr7Z5avhb5J+MXKAhPZN_mtvCzbHoXJiA@mail.gmail.com> In-Reply-To: <CACNAnaHsuz=1=AxdGhr7Z5avhb5J+MXKAhPZN_mtvCzbHoXJiA@mail.gmail.com> --P6HVEqyz4GHEQz3uca9XPfa6h6vjHqUJ1 Content-Type: multipart/mixed; boundary="------------7BA8203B11C4851DE8BDD5E3" Content-Language: en-US This is a multi-part message in MIME format. --------------7BA8203B11C4851DE8BDD5E3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Am 28.10.20 um 14:34 schrieb Kyle Evans: > On Wed, Oct 28, 2020 at 8:24 AM Stefan Esser <se@freebsd.org> wrote: >> I'm thinking about support for nested conditionals and #else in >> calendar files, but I'm not sure about the possibility to MFC >> such a change and I do not want to invite users to create calendar >> files that work in -CURRENT but not in -STABLE. >=20 > Unsolicited $0.02: Do whatever you feel comfortable with. It's up to > people trying to use the new/advanced features to make sure it's > compatible with the calendar(1) that *they* are using, and I'm having > a hard time imagining folks using deploying additional calendar data > in ports outside of deskutils/calendar-data which you can curate for > stuff like that. I only read your reply after committing the change that allows for recursion. The issue reported by Julian H. Stacey on the freebsd-stable list made me check for the code that implements these conditions, and I noticed that there was no #ifdef (which he had tried to use), but it was trivial to implement. The man-page mentions that a restricted subset of CPP directives is supported, and ISTR that an earlier version of the calendar program actually forked CPP to pre-process the data files. This approach required a "traditional" CPP that ignored the content of the non-directives being processed, which is no longer available. In a way I'm removing some of the limitations that resulted from the switch to an internal parser for the conditions. If there is consensus not to introduce any new features into our calendar program, then I'm going to revert these changes. I had planned to give time for a discussion about a possible merge to -STABLE. I have already created a port of the calendar program as deskutils/calendar and was planning to upgrade the port to include these changes in -CURRENT. The port could be used to provide release users with these features, if they consider them useful. Since the changes are fully compatible with old data files, I do not think that a MFC was a violation of POLA. We do now have the calendar-data port for use in -CURRENT and it could be used to distribute calendar files that use the new features. Since old calendar programs will not look into the port's data file directory, they will continue to operate on files in the base system. If the calendar program from a port is used, it will support the features of this version and that all calendar files that take advantage of them. We might hide these new features by removal from the man-page or we could discourage their use by declaring them unportable extensions. Regards, STefan --------------7BA8203B11C4851DE8BDD5E3-- --P6HVEqyz4GHEQz3uca9XPfa6h6vjHqUJ1-- --SraZyjpp1MzbUeqQKnszS3zpdRXMoSNbS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl+ZiYsFAwAAAAAACgkQR+u171r99URN LQf+McspM8jkHIgY1mTVchJQQXfu2VL9hx9N3rQ1TAzFIskD9ZBydeUpJJ6lqdXLFel3RLvhwxGk BXilylVtFEkV+kwfaHYAlY0625AkBVNCdai96EG2s882ze1D8e85Si5BeXf6dUxBX9zy5gy972H8 VrFaYIoK5n69fwrRAGbQRwcg0fNi1iA4lftnk19fL9lVOGAUdh9fvkQi0fqBZgOvdPv3mizWUTdB c3t00ABk8QgqdY0R0h1TiiH/M5Uv1ngMYVtWoTIOyKFR/hM+cwnOAmTt5/csp0rrgHOCZPxzlHrZ VrHobkEOHKOnjZHcC9q0dlXdj23u6oUX3boTidhgGw== =96nR -----END PGP SIGNATURE----- --SraZyjpp1MzbUeqQKnszS3zpdRXMoSNbS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46d724c0-87b8-740c-777d-f699527ccb6e>