Date: Wed, 30 Aug 2023 21:53:20 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Kevin Bowling <kbowling@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, mmendoza@netgate.com Subject: Re: git: b6b75424c57d - main - vmxnet3: Don't restart on VLAN changes Message-ID: <34CADCBB-B5E2-4E41-816E-4FAD36C474C3@FreeBSD.org> In-Reply-To: <202308242051.37OKpwUA039462@gitrepo.freebsd.org> References: <202308242051.37OKpwUA039462@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 24 Aug 2023, at 22:51, Kevin Bowling wrote: > The branch main has been updated by kbowling: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=b6b75424c57d6da49967fef39f69080ce6939207 > > commit b6b75424c57d6da49967fef39f69080ce6939207 > Author: Kevin Bowling <kbowling@FreeBSD.org> > AuthorDate: 2023-08-24 20:25:21 +0000 > Commit: Kevin Bowling <kbowling@FreeBSD.org> > CommitDate: 2023-08-24 20:46:56 +0000 > > vmxnet3: Don't restart on VLAN changes > > In rS360398, a new iflib device method was added with default of > opt out > for VLAN events needing an interface reset. > > This re-init is unintentional for vmxnet3(4). > It looks like we do need to re-init vmx interfaces when vlans are set. Marcos has an ESXi 7.0.3 setup that breaks with this patch series. This fixes it: diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_vmx.c index 2c3530a217f..fdcad0dd4bb 100644 --- a/sys/dev/vmware/vmxnet3/if_vmx.c +++ b/sys/dev/vmware/vmxnet3/if_vmx.c @@ -2513,6 +2513,7 @@ vmxnet3_if_needs_restart(if_ctx_t ctx __unused, enum iflib_restart_event event) { switch (event) { case IFLIB_RESTART_VLAN_CONFIG: + return (true); default: return (false); } Best regards, Kristof [-- Attachment #2 --] <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8"> </head> <body><div style="font-family: sans-serif;"><div class="markdown" style="white-space: normal;"> <p dir="auto">On 24 Aug 2023, at 22:51, Kevin Bowling wrote:</p> </div><div class="plaintext" style="white-space: normal;"><blockquote style="margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136BCE; color: #136BCE;"><p dir="auto">The branch main has been updated by kbowling:</p> <p dir="auto">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=b6b75424c57d6da49967fef39f69080ce6939207">https://cgit.FreeBSD.org/src/commit/?id=b6b75424c57d6da49967fef39f69080ce6939207</a></p>; <p dir="auto">commit b6b75424c57d6da49967fef39f69080ce6939207 <br> Author: Kevin Bowling <kbowling@FreeBSD.org> <br> AuthorDate: 2023-08-24 20:25:21 +0000 <br> Commit: Kevin Bowling <kbowling@FreeBSD.org> <br> CommitDate: 2023-08-24 20:46:56 +0000</p> <p dir="auto"> vmxnet3: Don't restart on VLAN changes</p> <p dir="auto"> In rS360398, a new iflib device method was added with default of opt out <br> for VLAN events needing an interface reset.</p> <p dir="auto"> This re-init is unintentional for vmxnet3(4).</p> <br></blockquote></div> <div class="markdown" style="white-space: normal;"> <p dir="auto">It looks like we do need to re-init vmx interfaces when vlans are set. Marcos has an ESXi 7.0.3 setup that breaks with this patch series.<br> This fixes it:</p> <pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_vmx.c index 2c3530a217f..fdcad0dd4bb 100644 --- a/sys/dev/vmware/vmxnet3/if_vmx.c +++ b/sys/dev/vmware/vmxnet3/if_vmx.c @@ -2513,6 +2513,7 @@ vmxnet3_if_needs_restart(if_ctx_t ctx __unused, enum iflib_restart_event event) { switch (event) { case IFLIB_RESTART_VLAN_CONFIG: + return (true); default: return (false); } </code></pre> <p dir="auto">Best regards,<br> Kristof</p> </div> </div> </body> </html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?34CADCBB-B5E2-4E41-816E-4FAD36C474C3>