Date: Thu, 1 Jun 2017 09:17:57 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, Brooks Davis <brooks@FreeBSD.org> Cc: Ngie Cooper <ngie@FreeBSD.org>, Marcel Moolenaar <marcel@freebsd.org>, "Simon J. Gerraty" <sjg@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <7d59fb7c-7ac6-c545-103d-6185a2ee5c93@FreeBSD.org> In-Reply-To: <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/01/17 01:06, Ngie Cooper (yaneurabeya) wrote: >> On May 31, 2017, at 10:03 PM, Brooks Davis <brooks@FreeBSD.org> wrote: >> >> On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: >>> Author: ngie >>> Date: Wed May 31 08:01:12 2017 >>> New Revision: 319295 >>> URL: https://svnweb.freebsd.org/changeset/base/319295 >>> >>> Log: >>> Update the usr.bin/mkimg golden test output files after ^/head@r319125 >>> >>> ^/head@r319125 changed the location of the backup pmbr, requiring the >>> output files to be regenerated, since they're binary disk dumps. >>> >>> The output files were regenerated with "make rebase"--fixed in >>> ^/head@r319294. >> These should not be stored uuencoded. It serves no purpose other >> than bloating the repo and causing spammy commit mails like this one >> where we got a huge tail of garbage output. > Hi Brooks, > I’m not entirely sure why the files were uuencoded to be honest. I think that’s a good question for Marcel and some of the folks at Juniper, since they wrote the tool/tests. for the record, it used to be a common practice. I think it's legacy from the CVS days. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d59fb7c-7ac6-c545-103d-6185a2ee5c93>