Date: Mon, 02 Dec 2013 11:15:13 +0100 From: John Marino <freebsd.contact@marino.st> To: mike <mike@reifenberger.com> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r334598 - head/cad/kicad-devel Message-ID: <529C5DB1.6040800@marino.st> In-Reply-To: <alpine.WNT.2.00.1312021004480.3396@ux32.win.rm-i.net> References: <201311221507.rAMF7cFW029817@svn.freebsd.org> <20131122155340.GA57808@FreeBSD.org> <alpine.WNT.2.00.1312021004480.3396@ux32.win.rm-i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/2/2013 10:12, mike wrote: > On Fri, 22 Nov 2013, Alexey Dokuchaev wrote: > ... >>> Log: >>> Use gcc for now. >> >> That's a notoriously bad commit message. Thanks for being C.O. >> explaining >> the diff, but commit logs are supposed to tell us something about >> *why* the >> particular change was made. >> > > Sorry for not replying sooner. > > I assumed that its obvious that a port gets only hardcoded to gcc in the > case of a build error with clang. > > So the commit line should have been: > > Use gcc for now because of an build error with clang. That's hardly better. Why not include the actual error in the commit message? That is done often to justify marking it as broken, it could also be done to explain the workaround. John P.S. To be fair, many folk here offer notoriously bad commit messages, frequently. I'm not sure why, maybe they just don't recognize it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?529C5DB1.6040800>