Date: Sat, 20 Jan 2018 18:36:00 +0000 From: "cem (Conrad Meyer)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D13995: NVMe controller emulator for bhyve. Message-ID: <7bf99cded0621f5537180125aef86e2b@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-vgewguea2dhplsjkeozl-req@FreeBSD.org> References: <differential-rev-PHID-DREV-vgewguea2dhplsjkeozl-req@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
cem added a reviewer: imp.
cem added a comment.
Awesome!
I can't speak to the NVMe emulation itself (I know almost nothing about the protocol and nothing about Bhyve HW emu interfaces). Maybe Warner can.
INLINE COMMENTS
> nvme.h:127
> enum shn_value {
> + NVME_SHN_NOEFCT = 0x0,
> NVME_SHN_NORMAL = 0x1,
indentation looks off here. is it just phabricator?
> Makefile:65
>
> -CFLAGS+= -I${BHYVE_SYSDIR}/sys/dev/usb/controller
> +CFLAGS+= -I${BHYVE_SYSDIR}/sys/dev/usb/controller -I${BHYVE_SYSDIR}/sys/dev/nvme/
>
don't need trailing slash
> pci_nvme.c:19
> +#ifdef NVME_DEBUG
> +static FILE* dbg;
> +#define DPRINTF(format, arg...) \
style nit: `static FILE *dbg;` (asterisk goes on the right side of the space)
> pci_nvme.c:21
> +#define DPRINTF(format, arg...) \
> + do { \
> + fprintf(dbg, format, ##arg); \
style nit: Should be tab indents throughout (can't tell if that's just Phab making it look like 4 spaces or actually 4 spaces).
REVISION DETAIL
https://reviews.freebsd.org/D13995
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sux2mfgj_gmail.com, grehan, trasz, imp
Cc: cem, freebsd-virtualization-list, chuck
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7bf99cded0621f5537180125aef86e2b>