Date: Wed, 24 Sep 2014 10:27:06 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272032 - head/sys/conf Message-ID: <5422E2CA.6050000@FreeBSD.org> In-Reply-To: <1598020.ur8YbI6DkF@ralph.baldwin.cx> References: <201409231704.s8NH4Lcv098184@svn.freebsd.org> <1598020.ur8YbI6DkF@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 9/24/2014 8:38 AM, John Baldwin wrote: > On Tuesday, September 23, 2014 05:04:21 PM Bryan Drewery wrote: >> Author: bdrewery >> Date: Tue Sep 23 17:04:21 2014 >> New Revision: 272032 >> URL: http://svnweb.freebsd.org/changeset/base/272032 >> >> Log: >> DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use it. >> fstat(1) now uses libprocstat(9). There is no userland impact to using >> this. > > As your followup noted, it does change the size of 'struct lock' (and thus > 'struct vnode') still. While fstat does not use it for live, it probably > still uses it for coredumps. However, lsof uses kvm access, so it will break. > I don't think that is worth noting here, but more of an FYI. > Hmm, I see my commit logs were not fully accurate. I was too focused on the stale comment about fstat(1). -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUIuLKAAoJEDXXcbtuRpfPCf0H/jMFpK2eaP3iC6MQD3uLvUnB Bn67mKToZ7q8YC9rli/sdNfjjgxwU5A+8rrw95cMSW37PEVZlZMqzzkfWegFi6Hf 5hViMnQLAxD1LNuYXIdcwh9DQbB0YI4E5SXkaXC5z9xGKOoVx8OVcLoJvTBrk23g aFW810OkMD6hdNo3B46vHgW7PyKFHg9idnTdTx6jbhkK0ILn/ssIg5QkrfrMW17i DYLJmGvxkOGF/a2JcF7Rhy+FHcGx17S4t2LQ9UOymqrqmfqT6dy0HSD8JHOqrOJH 4Ben8Qz8PNxwSkSBjn8MzZc65uOTYW8ZsitW0bRR5aGyV8ZhAaaYv4HfMoCJTFk= =NFEc -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5422E2CA.6050000>