Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 01 May 2021 23:43:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 255523] vn_generic_copy_file_range copies holes to EOF slowly
Message-ID:  <bug-255523-227-jLyt0K503t@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-255523-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-255523-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255523

--- Comment #4 from Alan Somers <asomers@FreeBSD.org> ---
Works for me!  I just have two comments about the patch:

* The (error =3D=3D 0) check at line 3118 can be removed if you just move
VOP_GETATTR two lines lower.
* Assigning false to holetoeof doesn't need to be done inside the loop.  You
can initialize it in its declaration.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255523-227-jLyt0K503t>