Date: Fri, 31 May 2002 18:05:05 -0700 (PDT) From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 12235 for review Message-ID: <200206010105.g51155B34947@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12235 Change 12235 by rwatson@rwatson_curry on 2002/05/31 18:04:54 Most of the calls to _valid() at the XXX locations in the old MAC code aren't actually needed, since almost all of those instances are called on now-internalized labels generated by mac_internalize() which also does validity checking. Eliminate many redundant label checks. Affected files ... ... //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#40 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#40 (text+ko) ==== @@ -1080,10 +1080,6 @@ new = SLOT(newlabel); - error = mac_biba_valid(new); - if (error) - return (error); - if ((new->mb_flags & MAC_BIBA_FLAGS_BOTH) != MAC_BIBA_FLAGS_BOTH) return (EINVAL); @@ -1099,10 +1095,6 @@ new = SLOT(newlabel); - error = mac_biba_valid(new); - if (error) - return (error); - if ((new->mb_flags & MAC_BIBA_FLAGS_BOTH) != MAC_BIBA_FLAG_SINGLE) return (EINVAL); @@ -1119,10 +1111,6 @@ new = SLOT(newlabel); - error = mac_biba_valid(new); - if (error) - return (error); - if ((new->mb_flags & MAC_BIBA_FLAGS_BOTH) != MAC_BIBA_FLAGS_BOTH) return (EINVAL); @@ -1145,10 +1133,6 @@ new = SLOT(newlabel); subj = SLOT(&cred->cr_label); - error = mac_biba_valid(new); - if (error) - return (error); - if ((new->mb_flags & MAC_BIBA_FLAGS_BOTH) != MAC_BIBA_FLAG_SINGLE) return (EINVAL); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206010105.g51155B34947>