Date: Thu, 9 Jul 2015 00:11:44 +0200 From: Zbigniew Bodek <zbb@freebsd.org> To: John-Mark Gurney <jmg@funkthat.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285270 - head/sys/sys Message-ID: <CALF_TxkFUc4NbWEZxFG15=yRb9FvFMiWFGnCmN65mCqurtY%2BDw@mail.gmail.com> In-Reply-To: <20150708194708.GQ8523@funkthat.com> References: <201507081353.t68Dr0up028388@repo.freebsd.org> <20150708194708.GQ8523@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello,
You are absolutely right. Especially semicolons... I must have missed
this somehow.
Thanks. Fixed in r285293.
Best regards
zbb
2015-07-08 21:47 GMT+02:00 John-Mark Gurney <jmg@funkthat.com>:
> Zbigniew Bodek wrote this message on Wed, Jul 08, 2015 at 13:53 +0000:
>> +#if defined(__arm__)
>> + #define __BUS_DMAMAP_SYNC_DEFAULT mb();
>> +#elif defined(__aarch64__)
>> + #define __BUS_DMAMAP_SYNC_DEFAULT dmb(sy);
>
> These shouldn't have ; after them...
>
>> +#else
>> + #define __BUS_DMAMAP_SYNC_DEFAULT {}
>
> The correct spelling of this should probably be:
> do { } while (0)
>
>> +#endif
>> #define bus_dmamap_sync(dmat, dmamap, op) \
>> do { \
>> if ((dmamap) != NULL) \
>> _bus_dmamap_sync(dmat, dmamap, op); \
>> + else \
>> + __BUS_DMAMAP_SYNC_DEFAULT \
>
> And then this can be properly written w/ a ; at the end...
>
> --
> John-Mark Gurney Voice: +1 415 225 5579
>
> "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALF_TxkFUc4NbWEZxFG15=yRb9FvFMiWFGnCmN65mCqurtY%2BDw>