Date: Fri, 14 May 2021 19:22:00 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: e894e3adb206 - main - cxgbei: Explicitly clear the page pode reservation pointer after freeing it. Message-ID: <202105141922.14EJM0YC058347@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=e894e3adb206815c2acff17a4011becb166c2f66 commit e894e3adb206815c2acff17a4011becb166c2f66 Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2021-05-14 19:20:51 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2021-05-14 19:21:34 +0000 cxgbei: Explicitly clear the page pode reservation pointer after freeing it. A single union ctl_io can be reused across multiple transfers (in particular by the ramdisk backend). On a reuse, the reservation pointer would retain its value from the previous transfer tripping an assertion. Reported by: Jithesh Arakkan @ Chelsio Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D29939 --- sys/dev/cxgbe/cxgbei/icl_cxgbei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/cxgbe/cxgbei/icl_cxgbei.c b/sys/dev/cxgbe/cxgbei/icl_cxgbei.c index e3dc05645732..7f638c96483a 100644 --- a/sys/dev/cxgbe/cxgbei/icl_cxgbei.c +++ b/sys/dev/cxgbe/cxgbei/icl_cxgbei.c @@ -1162,6 +1162,7 @@ icl_cxgbei_conn_transfer_done(struct icl_conn *ic, void *arg) t4_free_page_pods(prsv); uma_zfree(prsv_zone, prsv); + io_to_ppod_reservation(ctsio) = NULL; } }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105141922.14EJM0YC058347>